From d103f216b09c17fb60310cc6945ea8b6fbd9279b Mon Sep 17 00:00:00 2001 From: blam Date: Tue, 27 Aug 2024 17:08:16 +0200 Subject: [PATCH] chore: cleanup Signed-off-by: blam --- packages/core-compat-api/src/convertLegacyPlugin.test.tsx | 1 - packages/frontend-plugin-api/src/wiring/createFrontendPlugin.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/core-compat-api/src/convertLegacyPlugin.test.tsx b/packages/core-compat-api/src/convertLegacyPlugin.test.tsx index 3199355188..3d5b001c61 100644 --- a/packages/core-compat-api/src/convertLegacyPlugin.test.tsx +++ b/packages/core-compat-api/src/convertLegacyPlugin.test.tsx @@ -40,7 +40,6 @@ describe('convertLegacyPlugin', () => { "featureFlags": [], "getExtension": [Function], "id": "test", - "pluginId": "test", "routes": {}, "toString": [Function], "version": "v1", diff --git a/packages/frontend-plugin-api/src/wiring/createFrontendPlugin.ts b/packages/frontend-plugin-api/src/wiring/createFrontendPlugin.ts index 3d8c318354..185eabb985 100644 --- a/packages/frontend-plugin-api/src/wiring/createFrontendPlugin.ts +++ b/packages/frontend-plugin-api/src/wiring/createFrontendPlugin.ts @@ -128,7 +128,7 @@ export function createFrontendPlugin< return { $$type: '@backstage/FrontendPlugin', version: 'v1', - id: options.id, // TODO: Backwards compat to be able to install in older apps, remove after 1.31 + id: options.id, routes: options.routes ?? ({} as TRoutes), externalRoutes: options.externalRoutes ?? ({} as TExternalRoutes), featureFlags: options.featureFlags ?? [],