From bfa59576696f7d82bb8e6ea7485e261377eb3382 Mon Sep 17 00:00:00 2001 From: sblausten Date: Thu, 18 Nov 2021 18:25:43 +0100 Subject: [PATCH 1/2] Change sidebar to be pinned by default Signed-off-by: sblausten --- packages/core-components/src/layout/Sidebar/Page.tsx | 2 +- packages/core-components/src/layout/Sidebar/localStorage.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/core-components/src/layout/Sidebar/Page.tsx b/packages/core-components/src/layout/Sidebar/Page.tsx index cc50c5af6b..6248c237b2 100644 --- a/packages/core-components/src/layout/Sidebar/Page.tsx +++ b/packages/core-components/src/layout/Sidebar/Page.tsx @@ -49,7 +49,7 @@ export type SidebarPinStateContextType = { export const SidebarPinStateContext = createContext( { - isPinned: false, + isPinned: true, toggleSidebarPinState: () => {}, }, ); diff --git a/packages/core-components/src/layout/Sidebar/localStorage.ts b/packages/core-components/src/layout/Sidebar/localStorage.ts index 0e904ee319..78ec355306 100644 --- a/packages/core-components/src/layout/Sidebar/localStorage.ts +++ b/packages/core-components/src/layout/Sidebar/localStorage.ts @@ -24,10 +24,10 @@ export const LocalStorage = { try { value = JSON.parse( window.localStorage.getItem(LocalStorageKeys.SIDEBAR_PIN_STATE) || - 'false', + 'true', ); } catch { - return false; + return true; } return !!value; }, From 157530187ac221beae04921619d063304e833abd Mon Sep 17 00:00:00 2001 From: sblausten Date: Thu, 18 Nov 2021 19:00:28 +0100 Subject: [PATCH 2/2] Add Changeset Signed-off-by: sblausten --- .changeset/yellow-pandas-draw.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/yellow-pandas-draw.md diff --git a/.changeset/yellow-pandas-draw.md b/.changeset/yellow-pandas-draw.md new file mode 100644 index 0000000000..6d4f8116b3 --- /dev/null +++ b/.changeset/yellow-pandas-draw.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +Pin sidebar by default for easier navigation