From d0befd3fb23979f270ba91fc0ce9e4297deb9cd4 Mon Sep 17 00:00:00 2001 From: Eric Peterson Date: Wed, 22 Mar 2023 14:20:14 +0100 Subject: [PATCH] Fix guest/custom auth Signed-off-by: Eric Peterson --- .changeset/all-my-auth-wanna-ride-today.md | 5 +++++ packages/core-components/src/layout/SignInPage/providers.tsx | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 .changeset/all-my-auth-wanna-ride-today.md diff --git a/.changeset/all-my-auth-wanna-ride-today.md b/.changeset/all-my-auth-wanna-ride-today.md new file mode 100644 index 0000000000..40537c30f4 --- /dev/null +++ b/.changeset/all-my-auth-wanna-ride-today.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +Fixed a bug that could prevent auth from working when using the `guest` or `custom` auth providers. diff --git a/packages/core-components/src/layout/SignInPage/providers.tsx b/packages/core-components/src/layout/SignInPage/providers.tsx index 5e7ab7b7be..e456a6948b 100644 --- a/packages/core-components/src/layout/SignInPage/providers.tsx +++ b/packages/core-components/src/layout/SignInPage/providers.tsx @@ -177,7 +177,10 @@ export const useSignInProviders = ( }; const handleSignInStarted = () => { - localStorage.setItem(PROVIDER_STORAGE_KEY, provider.config!.id); + localStorage.setItem( + PROVIDER_STORAGE_KEY, + provider?.config?.id || provider.id, + ); }; const handleSignInFailure = () => {