From d02e5ee76197c4a818ebf29e847f698cd0a41745 Mon Sep 17 00:00:00 2001 From: Erik Engervall Date: Thu, 6 May 2021 14:10:08 +0200 Subject: [PATCH] Add X.error to onSuccess useAsyncs Signed-off-by: Erik Engervall --- .../CreateReleaseCandidate/hooks/useCreateReleaseCandidate.ts | 2 +- .../git-release-manager/src/features/Patch/hooks/usePatch.ts | 2 +- .../src/features/PromoteRc/hooks/usePromoteRc.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/git-release-manager/src/features/CreateReleaseCandidate/hooks/useCreateReleaseCandidate.ts b/plugins/git-release-manager/src/features/CreateReleaseCandidate/hooks/useCreateReleaseCandidate.ts index 5ab4fe2338..477e404d78 100644 --- a/plugins/git-release-manager/src/features/CreateReleaseCandidate/hooks/useCreateReleaseCandidate.ts +++ b/plugins/git-release-manager/src/features/CreateReleaseCandidate/hooks/useCreateReleaseCandidate.ts @@ -281,7 +281,7 @@ export function useCreateReleaseCandidate({ icon: 'success', }); } - }, [createReleaseRes.value]); + }, [createReleaseRes.value, createReleaseRes.error]); const TOTAL_STEPS = 6 + (!!onSuccess ? 1 : 0); const [progress, setProgress] = useState(0); diff --git a/plugins/git-release-manager/src/features/Patch/hooks/usePatch.ts b/plugins/git-release-manager/src/features/Patch/hooks/usePatch.ts index 7f1dc35667..506f218842 100644 --- a/plugins/git-release-manager/src/features/Patch/hooks/usePatch.ts +++ b/plugins/git-release-manager/src/features/Patch/hooks/usePatch.ts @@ -353,7 +353,7 @@ ${selectedPatchCommit.commit.message}`, message: 'Success callback successfully called 🚀', icon: 'success', }); - }, [updatedReleaseRes.value]); + }, [updatedReleaseRes.value, updatedReleaseRes.error]); const TOTAL_STEPS = 9 + (!!onSuccess ? 1 : 0); const [progress, setProgress] = useState(0); diff --git a/plugins/git-release-manager/src/features/PromoteRc/hooks/usePromoteRc.ts b/plugins/git-release-manager/src/features/PromoteRc/hooks/usePromoteRc.ts index 318c928479..8b1ffa089b 100644 --- a/plugins/git-release-manager/src/features/PromoteRc/hooks/usePromoteRc.ts +++ b/plugins/git-release-manager/src/features/PromoteRc/hooks/usePromoteRc.ts @@ -186,7 +186,7 @@ export function usePromoteRc({ icon: 'success', }); } - }, [promotedReleaseRes.value]); + }, [promotedReleaseRes.value, promotedReleaseRes.error]); const TOTAL_STEPS = 4 + (!!onSuccess ? 1 : 0); const [progress, setProgress] = useState(0);