From cfeaec21f9d9b2646ede2cfb34f95d623e6954cf Mon Sep 17 00:00:00 2001
From: blam <ben@blam.sh>
Date: Thu, 5 Sep 2024 16:42:35 +0200
Subject: [PATCH] chore: small cleanup

Signed-off-by: blam <ben@blam.sh>
---
 packages/core-components/api-report.md        | 26 ++++++--------
 .../FavoriteToggle/FavoriteToggle.test.tsx    |  4 +--
 .../FavoriteToggle/FavoriteToggle.tsx         | 35 +++++++++----------
 .../src/components/FavoriteToggle/index.ts    |  2 +-
 4 files changed, 30 insertions(+), 37 deletions(-)

diff --git a/packages/core-components/api-report.md b/packages/core-components/api-report.md
index c6ad474357..8062278c68 100644
--- a/packages/core-components/api-report.md
+++ b/packages/core-components/api-report.md
@@ -403,28 +403,22 @@ export type ErrorPanelProps = {
 };
 
 // @public
-export function FavoriteToggle({
-  id,
-  title,
-  isFavorite: value,
-  onToggle: onChange,
-  ...iconButtonProps
-}: FavoriteToggleProps): React_2.JSX.Element;
+export function FavoriteToggle(
+  props: ComponentProps<typeof IconButton> & {
+    id: string;
+    title: string;
+    isFavorite: boolean;
+    onToggle: (value: boolean) => void;
+  },
+): React_2.JSX.Element;
 
 // @public
-export function FavoriteToggleIcon({
-  isFavorite,
-}: {
+export function FavoriteToggleIcon(props: {
   isFavorite: boolean;
 }): React_2.JSX.Element;
 
 // @public (undocumented)
-export type FavoriteToggleProps = ComponentProps<typeof IconButton> & {
-  id: string;
-  title: string;
-  isFavorite: boolean;
-  onToggle: (value: boolean) => void;
-};
+export type FavoriteToggleIconClassKey = 'icon' | 'iconBorder';
 
 // @public (undocumented)
 export type FeatureCalloutCircleClassKey =
diff --git a/packages/core-components/src/components/FavoriteToggle/FavoriteToggle.test.tsx b/packages/core-components/src/components/FavoriteToggle/FavoriteToggle.test.tsx
index d40e3c99b3..c5ca4c33f2 100644
--- a/packages/core-components/src/components/FavoriteToggle/FavoriteToggle.test.tsx
+++ b/packages/core-components/src/components/FavoriteToggle/FavoriteToggle.test.tsx
@@ -14,14 +14,14 @@
  * limitations under the License.
  */
 import { render } from '@testing-library/react';
-import { FavoriteToggle, FavoriteToggleProps } from './FavoriteToggle';
+import { FavoriteToggle } from './FavoriteToggle';
 import React from 'react';
 import userEvent from '@testing-library/user-event';
 
 describe('<FavoriteToggle />', () => {
   const onToggle = jest.fn();
 
-  const props: FavoriteToggleProps = {
+  const props = {
     title: 'Favorite this thing',
     id: 'some-thing-favorite',
     onToggle,
diff --git a/packages/core-components/src/components/FavoriteToggle/FavoriteToggle.tsx b/packages/core-components/src/components/FavoriteToggle/FavoriteToggle.tsx
index c315efbd68..65124ab05c 100644
--- a/packages/core-components/src/components/FavoriteToggle/FavoriteToggle.tsx
+++ b/packages/core-components/src/components/FavoriteToggle/FavoriteToggle.tsx
@@ -39,16 +39,6 @@ const useStyles = makeStyles<Theme>(
  */
 export type FavoriteToggleIconClassKey = 'icon' | 'iconBorder';
 
-/**
- * @public
- */
-export type FavoriteToggleProps = ComponentProps<typeof IconButton> & {
-  id: string;
-  title: string;
-  isFavorite: boolean;
-  onToggle: (value: boolean) => void;
-};
-
 /**
  * Icon used in FavoriteToggle component.
  *
@@ -56,7 +46,8 @@ export type FavoriteToggleProps = ComponentProps<typeof IconButton> & {
  *
  * @public
  */
-export function FavoriteToggleIcon({ isFavorite }: { isFavorite: boolean }) {
+export function FavoriteToggleIcon(props: { isFavorite: boolean }) {
+  const { isFavorite } = props;
   const classes = useStyles();
 
   return isFavorite ? (
@@ -74,13 +65,21 @@ export function FavoriteToggleIcon({ isFavorite }: { isFavorite: boolean }) {
  *
  * @public
  */
-export function FavoriteToggle({
-  id,
-  title,
-  isFavorite: value,
-  onToggle: onChange,
-  ...iconButtonProps
-}: FavoriteToggleProps) {
+export function FavoriteToggle(
+  props: ComponentProps<typeof IconButton> & {
+    id: string;
+    title: string;
+    isFavorite: boolean;
+    onToggle: (value: boolean) => void;
+  },
+) {
+  const {
+    id,
+    title,
+    isFavorite: value,
+    onToggle: onChange,
+    ...iconButtonProps
+  } = props;
   return (
     <Tooltip id={id} title={title}>
       <IconButton
diff --git a/packages/core-components/src/components/FavoriteToggle/index.ts b/packages/core-components/src/components/FavoriteToggle/index.ts
index 539bb1baf9..460b162bdf 100644
--- a/packages/core-components/src/components/FavoriteToggle/index.ts
+++ b/packages/core-components/src/components/FavoriteToggle/index.ts
@@ -15,4 +15,4 @@
  */
 
 export { FavoriteToggle, FavoriteToggleIcon } from './FavoriteToggle';
-export type { FavoriteToggleProps } from './FavoriteToggle';
+export type { FavoriteToggleIconClassKey } from './FavoriteToggle';