From cf3de79c245b42706b7741a24572096e25d2f747 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 12 Aug 2024 09:52:35 +0200 Subject: [PATCH] frontend-plugin-api: allow clearing multi inputs Signed-off-by: Patrik Oldsberg --- .../frontend-plugin-api/src/wiring/createExtension.test.ts | 4 ++-- .../src/wiring/createExtensionBlueprint.test.tsx | 4 ++-- .../src/wiring/createExtensionBlueprint.ts | 5 ++++- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/frontend-plugin-api/src/wiring/createExtension.test.ts b/packages/frontend-plugin-api/src/wiring/createExtension.test.ts index d6e2599138..014ccf4a40 100644 --- a/packages/frontend-plugin-api/src/wiring/createExtension.test.ts +++ b/packages/frontend-plugin-api/src/wiring/createExtension.test.ts @@ -850,7 +850,7 @@ describe('createExtension', () => { return originalFactory({ inputs: { single: [testDataRef1('single')], - multi: [[testDataRef1('multi1')], [testDataRef1('multi2')]], + multi: [], }, }); }, @@ -865,7 +865,7 @@ describe('createExtension', () => { opt: 'none', single: 'single', singleOpt: 'none', - multi: 'multi1,multi2', + multi: '', }); // Forward inputs directly diff --git a/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.test.tsx b/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.test.tsx index 508000acbb..57b0629859 100644 --- a/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.test.tsx +++ b/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.test.tsx @@ -426,7 +426,7 @@ describe('createExtensionBlueprint', () => { { inputs: { single: [testDataRef1('single')], - multi: [[testDataRef1('multi1')], [testDataRef1('multi2')]], + multi: [], }, }, ); @@ -439,7 +439,7 @@ describe('createExtensionBlueprint', () => { opt: 'none', single: 'single', singleOpt: 'none', - multi: 'multi1,multi2', + multi: '', }), ]); diff --git a/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.ts b/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.ts index 74d4426207..8175a25212 100644 --- a/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.ts +++ b/packages/frontend-plugin-api/src/wiring/createExtensionBlueprint.ts @@ -353,7 +353,10 @@ export function resolveInputOverrides( `override data provided for input '${name}' must be an array`, ); } - if (originalInput.length !== providedData.length) { + if ( + originalInput.length !== providedData.length && + providedData.length > 0 + ) { throw new Error( `override data provided for input '${name}' must match the length of the original inputs`, );