Address comments on pr for k8s oidc authProvider

Signed-off-by: Daniel Bravo <dbravo@vmware.com>
This commit is contained in:
Daniel Bravo
2022-05-06 15:34:33 -05:00
parent 447e060872
commit cdf3ca2b84
8 changed files with 33 additions and 25 deletions
@@ -58,7 +58,7 @@ describe('KubernetesAuthProviders tests', () => {
requestBody,
);
expect(details.oidc?.okta).toBe('oktaToken');
expect(details.auth?.oidc?.okta).toBe('oktaToken');
});
it('returns error for unknown authProvider', async () => {
@@ -31,11 +31,13 @@ export class OidcKubernetesAuthProvider implements KubernetesAuthProvider {
requestBody: KubernetesRequestBody,
): Promise<KubernetesRequestBody> {
const authToken: string = await this.authProvider.getIdToken();
if ('oidc' in requestBody) {
requestBody.oidc![this.providerName] = authToken;
const auth = { ...requestBody.auth };
if (auth.oidc) {
auth.oidc[this.providerName] = authToken;
} else {
requestBody.oidc = { [this.providerName]: authToken };
auth.oidc = { [this.providerName]: authToken };
}
requestBody.auth = auth;
return requestBody;
}
}