Address comments on pr for k8s oidc authProvider
Signed-off-by: Daniel Bravo <dbravo@vmware.com>
This commit is contained in:
@@ -58,7 +58,7 @@ describe('KubernetesAuthProviders tests', () => {
|
||||
requestBody,
|
||||
);
|
||||
|
||||
expect(details.oidc?.okta).toBe('oktaToken');
|
||||
expect(details.auth?.oidc?.okta).toBe('oktaToken');
|
||||
});
|
||||
|
||||
it('returns error for unknown authProvider', async () => {
|
||||
|
||||
@@ -31,11 +31,13 @@ export class OidcKubernetesAuthProvider implements KubernetesAuthProvider {
|
||||
requestBody: KubernetesRequestBody,
|
||||
): Promise<KubernetesRequestBody> {
|
||||
const authToken: string = await this.authProvider.getIdToken();
|
||||
if ('oidc' in requestBody) {
|
||||
requestBody.oidc![this.providerName] = authToken;
|
||||
const auth = { ...requestBody.auth };
|
||||
if (auth.oidc) {
|
||||
auth.oidc[this.providerName] = authToken;
|
||||
} else {
|
||||
requestBody.oidc = { [this.providerName]: authToken };
|
||||
auth.oidc = { [this.providerName]: authToken };
|
||||
}
|
||||
requestBody.auth = auth;
|
||||
return requestBody;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user