From 50a331b16adf1d0a92186a319aed6b4c6257b72c Mon Sep 17 00:00:00 2001 From: blam Date: Fri, 15 Mar 2024 12:44:51 +0100 Subject: [PATCH] chore: use return await to make sure that the promise is settled before returning Signed-off-by: blam --- .changeset/metal-toes-mate.md | 5 +++++ plugins/auth-backend-module-guest-provider/src/resolvers.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/metal-toes-mate.md diff --git a/.changeset/metal-toes-mate.md b/.changeset/metal-toes-mate.md new file mode 100644 index 0000000000..8ad933eda0 --- /dev/null +++ b/.changeset/metal-toes-mate.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-auth-backend-module-guest-provider': patch +--- + +Fix issue for issuing a token when `guest` user does not exist in catalog diff --git a/plugins/auth-backend-module-guest-provider/src/resolvers.ts b/plugins/auth-backend-module-guest-provider/src/resolvers.ts index 35f724f746..cb4e59704c 100644 --- a/plugins/auth-backend-module-guest-provider/src/resolvers.ts +++ b/plugins/auth-backend-module-guest-provider/src/resolvers.ts @@ -46,7 +46,7 @@ export const signInAsGuestUser: (config: Config) => SignInResolver<{}> = 'ownershipEntityRefs', ) ?? [userRef]; try { - return ctx.signInWithCatalogUser({ entityRef: userRef }); + return await ctx.signInWithCatalogUser({ entityRef: userRef }); } catch (err) { // We can't guarantee that a guest user exists in the catalog, so we issue a token directly, return ctx.issueToken({