From cd48d9751c77cd76195bcc42a7357c01a6701f1a Mon Sep 17 00:00:00 2001 From: Yingbai He Date: Tue, 26 Nov 2024 11:05:49 -0800 Subject: [PATCH] chore(TechDocs): extract `defaultColumns` into the columns util file Signed-off-by: Yingbai He --- .../techdocs/src/home/components/Tables/DocsTable.tsx | 10 +--------- .../src/home/components/Tables/EntityListDocsTable.tsx | 10 +--------- .../techdocs/src/home/components/Tables/columns.tsx | 8 ++++++++ 3 files changed, 10 insertions(+), 18 deletions(-) diff --git a/plugins/techdocs/src/home/components/Tables/DocsTable.tsx b/plugins/techdocs/src/home/components/Tables/DocsTable.tsx index b1537affdb..850ce4250b 100644 --- a/plugins/techdocs/src/home/components/Tables/DocsTable.tsx +++ b/plugins/techdocs/src/home/components/Tables/DocsTable.tsx @@ -33,7 +33,7 @@ import { TableProps, } from '@backstage/core-components'; import { actionFactories } from './actions'; -import { columnFactories } from './columns'; +import { columnFactories, defaultColumns } from './columns'; import { toLowerMaybe } from '../../../helpers'; import { DocsTableRow } from './types'; @@ -51,14 +51,6 @@ export type DocsTableProps = { options?: TableOptions; }; -const defaultColumns: TableColumn[] = [ - columnFactories.createTitleColumn({ hidden: true }), - columnFactories.createNameColumn(), - columnFactories.createOwnerColumn(), - columnFactories.createKindColumn(), - columnFactories.createTypeColumn(), -]; - /** * Component which renders a table documents * diff --git a/plugins/techdocs/src/home/components/Tables/EntityListDocsTable.tsx b/plugins/techdocs/src/home/components/Tables/EntityListDocsTable.tsx index 6ed3138c01..959644ca19 100644 --- a/plugins/techdocs/src/home/components/Tables/EntityListDocsTable.tsx +++ b/plugins/techdocs/src/home/components/Tables/EntityListDocsTable.tsx @@ -36,7 +36,7 @@ import { DocsTable } from './DocsTable'; import { OffsetPaginatedDocsTable } from './OffsetPaginatedDocsTable'; import { CursorPaginatedDocsTable } from './CursorPaginatedDocsTable'; import { actionFactories } from './actions'; -import { columnFactories } from './columns'; +import { columnFactories, defaultColumns } from './columns'; import { DocsTableRow } from './types'; import { toLowerMaybe } from '../../../helpers'; import { rootDocsRouteRef } from '../../../routes'; @@ -52,14 +52,6 @@ export type EntityListDocsTableProps = { options?: TableOptions; }; -const defaultColumns: TableColumn[] = [ - columnFactories.createTitleColumn({ hidden: true }), - columnFactories.createNameColumn(), - columnFactories.createOwnerColumn(), - columnFactories.createKindColumn(), - columnFactories.createTypeColumn(), -]; - /** * Component which renders a table with entities from catalog. * diff --git a/plugins/techdocs/src/home/components/Tables/columns.tsx b/plugins/techdocs/src/home/components/Tables/columns.tsx index ef22f6d288..9947e1de9e 100644 --- a/plugins/techdocs/src/home/components/Tables/columns.tsx +++ b/plugins/techdocs/src/home/components/Tables/columns.tsx @@ -85,3 +85,11 @@ export const columnFactories = { }; }, }; + +export const defaultColumns: TableColumn[] = [ + columnFactories.createTitleColumn({ hidden: true }), + columnFactories.createNameColumn(), + columnFactories.createOwnerColumn(), + columnFactories.createKindColumn(), + columnFactories.createTypeColumn(), +];