From eb3f4cbb58e17fe699f52c47669de2a42924d883 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 2 Dec 2020 21:04:42 -0500 Subject: [PATCH 1/3] Align plugin ID --- plugins/catalog-import/src/api/CatalogImportApi.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/catalog-import/src/api/CatalogImportApi.ts b/plugins/catalog-import/src/api/CatalogImportApi.ts index 49012764e2..0ce569171f 100644 --- a/plugins/catalog-import/src/api/CatalogImportApi.ts +++ b/plugins/catalog-import/src/api/CatalogImportApi.ts @@ -18,7 +18,7 @@ import { createApiRef } from '@backstage/core'; import { PartialEntity } from '../util/types'; export const catalogImportApiRef = createApiRef({ - id: 'plugin.catalogimport.service', + id: 'plugin.catalog-import.service', description: 'Used by the catalog import plugin to make requests', }); From c02db852a2fd577d5f21458b696ea1e8ead46f87 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 2 Dec 2020 21:05:16 -0500 Subject: [PATCH 2/3] Fix variable typo --- plugins/catalog-import/src/api/CatalogImportClient.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/catalog-import/src/api/CatalogImportClient.ts b/plugins/catalog-import/src/api/CatalogImportClient.ts index 94ba260d55..aaa110329e 100644 --- a/plugins/catalog-import/src/api/CatalogImportClient.ts +++ b/plugins/catalog-import/src/api/CatalogImportClient.ts @@ -160,7 +160,7 @@ export class CatalogImportClient implements CatalogImportApi { ); }); - const pullRequestRespone = await octo.pulls + const pullRequestResponse = await octo.pulls .create({ owner, repo, @@ -178,7 +178,7 @@ export class CatalogImportClient implements CatalogImportApi { }); return { - link: pullRequestRespone.data.html_url, + link: pullRequestResponse.data.html_url, location: `https://github.com/${owner}/${repo}/blob/${repoData.data.default_branch}/${fileName}`, }; } From 79418ddb6295a469e1bf4c1c65e5f6bad28cea0a Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 2 Dec 2020 21:07:40 -0500 Subject: [PATCH 3/3] Add changeset --- .changeset/grumpy-meals-wink.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/grumpy-meals-wink.md diff --git a/.changeset/grumpy-meals-wink.md b/.changeset/grumpy-meals-wink.md new file mode 100644 index 0000000000..8fb346b831 --- /dev/null +++ b/.changeset/grumpy-meals-wink.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog-import': patch +--- + +Align plugin ID and fix variable typo