Merge pull request #5351 from backstage/rugvip/plugin-detective

core: allow plugins to be discovered through the react tree
This commit is contained in:
Patrik Oldsberg
2021-04-16 10:42:30 +02:00
committed by GitHub
10 changed files with 54 additions and 72 deletions
@@ -106,24 +106,6 @@ export async function addPluginDependencyToApp(
});
}
export async function addPluginImportToApp(
rootDir: string,
pluginVar: string,
pluginPackage: string,
) {
const pluginExport = `export { ${pluginVar} } from '${pluginPackage}';`;
const pluginsFilePath = 'packages/app/src/plugins.ts';
const pluginsFile = resolvePath(rootDir, pluginsFilePath);
await Task.forItem('processing', pluginsFilePath, async () => {
await addExportStatement(pluginsFile, pluginExport).catch(error => {
throw new Error(
`Failed to import plugin in app: ${pluginsFile}: ${error.message}`,
);
});
});
}
export async function addPluginExtensionToApp(
pluginId: string,
extensionName: string,
@@ -320,7 +302,6 @@ export default async (cmd: Command) => {
await addPluginDependencyToApp(paths.targetRoot, name, pluginVersion);
Task.section('Import plugin in app');
await addPluginImportToApp(paths.targetRoot, pluginVar, name);
await addPluginExtensionToApp(pluginId, extensionName, name);
}