From cbb85e07f0687121c490a7b63df1594b108293ae Mon Sep 17 00:00:00 2001 From: MT Lewis Date: Wed, 22 Dec 2021 10:17:21 +0000 Subject: [PATCH] permission-node: simplify undefined check and fix applyConditions signature Signed-off-by: MT Lewis --- .../src/integration/createPermissionIntegrationRouter.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/permission-node/src/integration/createPermissionIntegrationRouter.ts b/plugins/permission-node/src/integration/createPermissionIntegrationRouter.ts index 0fdbab7a9f..747e47b87d 100644 --- a/plugins/permission-node/src/integration/createPermissionIntegrationRouter.ts +++ b/plugins/permission-node/src/integration/createPermissionIntegrationRouter.ts @@ -93,13 +93,13 @@ export type ApplyConditionsResponse = ApplyConditionsResponseEntry[]; const applyConditions = ( criteria: PermissionCriteria, - resource: TResource, + resource: TResource | undefined, getRule: (name: string) => PermissionRule, ): boolean => { // If resource was not found, deny. This avoids leaking information from the // apply-conditions API which would allow a user to differentiate between // non-existent resources and resources to which they do not have access. - if (typeof resource === 'undefined') { + if (resource === undefined) { return false; }