From c1164fb6a8f45d7870e51c698113ba386d169b58 Mon Sep 17 00:00:00 2001
From: blam <ben@blam.sh>
Date: Thu, 11 Feb 2021 20:09:24 +0100
Subject: [PATCH 1/3] bug: filepath can be returned as undefined from
 `git-url-parse` let's default to empty

---
 .../src/scaffolder/stages/prepare/bitbucket.ts                  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/scaffolder-backend/src/scaffolder/stages/prepare/bitbucket.ts b/plugins/scaffolder-backend/src/scaffolder/stages/prepare/bitbucket.ts
index d473656863..02865f8529 100644
--- a/plugins/scaffolder-backend/src/scaffolder/stages/prepare/bitbucket.ts
+++ b/plugins/scaffolder-backend/src/scaffolder/stages/prepare/bitbucket.ts
@@ -43,7 +43,7 @@ export class BitbucketPreparer implements PreparerBase {
     const targetPath = path.join(workspacePath, 'template');
     const fullPathToTemplate = path.resolve(
       checkoutPath,
-      parsedGitUrl.filepath,
+      parsedGitUrl.filepath ?? '',
     );
 
     const git = Git.fromAuth({ logger, ...this.getAuth() });

From c6a67b100e78a0e1c34ca9b1cbd733dd4859a39c Mon Sep 17 00:00:00 2001
From: blam <ben@blam.sh>
Date: Thu, 11 Feb 2021 20:10:20 +0100
Subject: [PATCH 2/3] chore: might as well do this for all parsing

---
 .../scaffolder-backend/src/scaffolder/stages/prepare/github.ts  | 2 +-
 .../scaffolder-backend/src/scaffolder/stages/prepare/gitlab.ts  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugins/scaffolder-backend/src/scaffolder/stages/prepare/github.ts b/plugins/scaffolder-backend/src/scaffolder/stages/prepare/github.ts
index 533aa8e005..77e6ec6d70 100644
--- a/plugins/scaffolder-backend/src/scaffolder/stages/prepare/github.ts
+++ b/plugins/scaffolder-backend/src/scaffolder/stages/prepare/github.ts
@@ -33,7 +33,7 @@ export class GithubPreparer implements PreparerBase {
     const targetPath = path.join(workspacePath, 'template');
     const fullPathToTemplate = path.resolve(
       checkoutPath,
-      parsedGitUrl.filepath,
+      parsedGitUrl.filepath ?? '',
     );
 
     const git = this.config.token
diff --git a/plugins/scaffolder-backend/src/scaffolder/stages/prepare/gitlab.ts b/plugins/scaffolder-backend/src/scaffolder/stages/prepare/gitlab.ts
index fa5c8c1325..e15de33ac6 100644
--- a/plugins/scaffolder-backend/src/scaffolder/stages/prepare/gitlab.ts
+++ b/plugins/scaffolder-backend/src/scaffolder/stages/prepare/gitlab.ts
@@ -33,7 +33,7 @@ export class GitlabPreparer implements PreparerBase {
     const targetPath = path.join(workspacePath, 'template');
     const fullPathToTemplate = path.resolve(
       checkoutPath,
-      parsedGitUrl.filepath,
+      parsedGitUrl.filepath ?? '',
     );
     parsedGitUrl.git_suffix = true;
 

From a341a8716a979364b5e801a826136ecf9c8d4bca Mon Sep 17 00:00:00 2001
From: blam <ben@blam.sh>
Date: Thu, 11 Feb 2021 20:14:47 +0100
Subject: [PATCH 3/3] chore: changeset

---
 .changeset/tough-worms-clap.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/tough-worms-clap.md

diff --git a/.changeset/tough-worms-clap.md b/.changeset/tough-worms-clap.md
new file mode 100644
index 0000000000..3a18593549
--- /dev/null
+++ b/.changeset/tough-worms-clap.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-scaffolder-backend': patch
+---
+
+Fix parsing of the path to default to empty string not undefined if git-url-parse throws something we don't expect. Fixes the error `The "path" argument must be of type string.` when preparing.