From ee653a97c52c0f9e3237f8088b78d98339ecb940 Mon Sep 17 00:00:00 2001 From: Josh Maxwell Date: Sat, 22 Oct 2022 22:32:39 -0600 Subject: [PATCH 1/5] Using GitHub Integration Host information in place of static GitHub hostname Signed-off-by: Josh Maxwell --- .../src/components/GithubIssues/IssueCard/IssueCard.tsx | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/plugins/github-issues/src/components/GithubIssues/IssueCard/IssueCard.tsx b/plugins/github-issues/src/components/GithubIssues/IssueCard/IssueCard.tsx index bbc4995796..2337c8b4ac 100644 --- a/plugins/github-issues/src/components/GithubIssues/IssueCard/IssueCard.tsx +++ b/plugins/github-issues/src/components/GithubIssues/IssueCard/IssueCard.tsx @@ -14,14 +14,13 @@ * limitations under the License. */ -import React from 'react'; -import { DateTime } from 'luxon'; - -import { Box, Paper, Typography, CardActionArea } from '@material-ui/core'; import { Link } from '@backstage/core-components'; +import { Box, CardActionArea, Paper, Typography } from '@material-ui/core'; +import Divider from '@material-ui/core/Divider'; +import { DateTime } from 'luxon'; +import React from 'react'; import { Assignees } from './Assignees'; import { CommentsCount } from './CommentsCount'; -import Divider from '@material-ui/core/Divider'; type IssueCardProps = { title: string; From c8dd2a8c87df3dad1bae6577efca37d40cd196ed Mon Sep 17 00:00:00 2001 From: Josh Maxwell Date: Sun, 23 Oct 2022 13:34:19 -0600 Subject: [PATCH 2/5] Adding changeset Signed-off-by: Josh Maxwell --- .changeset/clean-feet-remain.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/clean-feet-remain.md diff --git a/.changeset/clean-feet-remain.md b/.changeset/clean-feet-remain.md new file mode 100644 index 0000000000..c8f301105c --- /dev/null +++ b/.changeset/clean-feet-remain.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-github-issues': patch +--- + +Respecting GitHub integration host value from catalog-info.yaml file From d331fe795ebf96929c9b8852b165385f287d0b03 Mon Sep 17 00:00:00 2001 From: Josh Maxwell Date: Mon, 24 Oct 2022 21:42:34 -0600 Subject: [PATCH 3/5] Replacing gitlab integration host with stripped url already present Signed-off-by: Josh Maxwell --- .../src/components/GithubIssues/IssueCard/IssueCard.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/github-issues/src/components/GithubIssues/IssueCard/IssueCard.tsx b/plugins/github-issues/src/components/GithubIssues/IssueCard/IssueCard.tsx index 2337c8b4ac..a5a5b79ac0 100644 --- a/plugins/github-issues/src/components/GithubIssues/IssueCard/IssueCard.tsx +++ b/plugins/github-issues/src/components/GithubIssues/IssueCard/IssueCard.tsx @@ -58,7 +58,7 @@ export const IssueCard = (props: IssueCardProps) => { - + {repositoryName} From 487507f2f11762701ca69322e610c1aa4da268c4 Mon Sep 17 00:00:00 2001 From: Josh Maxwell Date: Mon, 24 Oct 2022 21:45:04 -0600 Subject: [PATCH 4/5] Updating changeset message Signed-off-by: Josh Maxwell --- .changeset/clean-feet-remain.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/clean-feet-remain.md b/.changeset/clean-feet-remain.md index c8f301105c..f55a41a81a 100644 --- a/.changeset/clean-feet-remain.md +++ b/.changeset/clean-feet-remain.md @@ -2,4 +2,4 @@ '@backstage/plugin-github-issues': patch --- -Respecting GitHub integration host value from catalog-info.yaml file +Stripping specific issues url already present to target base issues url. From 23f827ff4f719f0d0adb8878079e03098bbabfb4 Mon Sep 17 00:00:00 2001 From: Josh Maxwell Date: Mon, 24 Oct 2022 21:47:57 -0600 Subject: [PATCH 5/5] Uppercasing URL to make spellchecker happy Signed-off-by: Josh Maxwell --- .changeset/clean-feet-remain.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/clean-feet-remain.md b/.changeset/clean-feet-remain.md index f55a41a81a..c712ef9e1e 100644 --- a/.changeset/clean-feet-remain.md +++ b/.changeset/clean-feet-remain.md @@ -2,4 +2,4 @@ '@backstage/plugin-github-issues': patch --- -Stripping specific issues url already present to target base issues url. +Stripping specific issues URL already present to target base issues URL.