From ca5f4002788ef6303a921fee2b363ef967f911a8 Mon Sep 17 00:00:00 2001 From: jrusso1020 Date: Wed, 2 Jun 2021 10:42:35 -0400 Subject: [PATCH] address feedback Signed-off-by: jrusso1020 --- .changeset/seven-badgers-marry.md | 2 +- .github/styles/vocab.txt | 4 ---- plugins/scaffolder-backend/src/service/router.ts | 8 ++++---- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/.changeset/seven-badgers-marry.md b/.changeset/seven-badgers-marry.md index 929ae99fac..7f36b03aa4 100644 --- a/.changeset/seven-badgers-marry.md +++ b/.changeset/seven-badgers-marry.md @@ -2,4 +2,4 @@ '@backstage/plugin-scaffolder-backend': minor --- -This adds a configuration option to the scaffolder plugin router, so we can allow for multiple taskworkers. Currently with only one taskworker you are limited to scaffolding one thing at a time. Set the `taskWorkers?: number` option in your scaffolder router to get more than 1 taskworker +This adds a configuration option to the scaffolder plugin router, so we can allow for multiple TaskWorkers. Currently with only one TaskWorker you are limited to scaffolding one thing at a time. Set the `taskWorkers?: number` option in your scaffolder router to get more than 1 TaskWorker diff --git a/.github/styles/vocab.txt b/.github/styles/vocab.txt index 2d24e8393b..b8f028a2ae 100644 --- a/.github/styles/vocab.txt +++ b/.github/styles/vocab.txt @@ -241,10 +241,6 @@ supertype talkdesk Talkdesk tasklist -taskworker -Taskworker -taskworkers -Taskworkers techdocs Telenor templated diff --git a/plugins/scaffolder-backend/src/service/router.ts b/plugins/scaffolder-backend/src/service/router.ts index 70fa58b027..e032a17561 100644 --- a/plugins/scaffolder-backend/src/service/router.ts +++ b/plugins/scaffolder-backend/src/service/router.ts @@ -105,16 +105,16 @@ export async function createRouter( ); const taskBroker = new StorageTaskBroker(databaseTaskStore, logger); const actionRegistry = new TemplateActionRegistry(); - const workers = new Array(taskWorkers || 1); - workers.map(_ => { + const workers = []; + for (let i = 0; i < (taskWorkers || 1); i++) { const worker = new TaskWorker({ logger, taskBroker, actionRegistry, workingDirectory, }); - return worker; - }); + workers.push(worker); + } const actionsToRegister = Array.isArray(actions) ? actions