Merge pull request #1757 from spotify/rugvip/typefix

yarn.lock,cli: bump failing type deps + run tsc after plugin creation in e2e test
This commit is contained in:
Patrik Oldsberg
2020-07-27 17:24:36 +02:00
committed by GitHub
4 changed files with 34 additions and 28 deletions
+1 -1
View File
@@ -215,7 +215,7 @@ async function createPlugin(pluginName, appDir) {
await waitForExit(child);
const pluginDir = resolvePath(appDir, 'plugins', pluginName);
for (const cmd of [['lint'], ['test', '--no-watch']]) {
for (const cmd of [['tsc'], ['lint'], ['test', '--no-watch']]) {
print(`Running 'yarn ${cmd.join(' ')}' in newly created plugin`);
await runPlain(['yarn', ...cmd], { cwd: pluginDir });
}
+1 -1
View File
@@ -92,7 +92,7 @@ export async function runCheck(cmd: string, ...args: string[]) {
}
export async function waitForExit(
child: ChildProcess & { exitCode?: number },
child: ChildProcess & { exitCode: number | null },
name?: string,
): Promise<void> {
if (typeof child.exitCode === 'number') {