paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 42 Packages Projects Releases Wiki Activity

Merge pull request #4131 from backstage/freben/no-annotation-merge

Browse Source 
catalog-model: remove special merge treatment of annotations
This commit is contained in:
Fredrik Adelöw
2021-01-18 18:50:23 +01:00
committed by GitHub
parent 6458dfeb14 a93f422132
commit c8e3e82ce2
3 changed files with 19 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/yellow-ties-switch.md
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/catalog-model': minor
---
The catalog no longer attempts to merge old and new annotations, when updating an entity from a remote location. This was a behavior that was copied from kubernetes, and catered to use cases where you wanted to use HTTP POST to update an entity in-place, outside of what the refresh loop does. This has proved to be a mistake, because as a side effect, the refresh loop effectively is unable to ever delete annotations when they are removed from source YAML. This is obviously a breaking change, but we believe that this is not a behavior that is relied upon in the wild, and it has never been an actually supported use flow of the catalog. We therefore choose to break the behavior outright, and instead just store updated annotations verbatim - just like we already do for example for labels