From c89e954bf401ac8097ec496a41ac6036ea3f03ad Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 15 Sep 2025 14:29:34 +0200 Subject: [PATCH] error collection: review fixes Signed-off-by: Patrik Oldsberg --- packages/frontend-app-api/src/wiring/createErrorCollector.ts | 2 +- packages/frontend-defaults/src/maybeCreateErrorPage.tsx | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/frontend-app-api/src/wiring/createErrorCollector.ts b/packages/frontend-app-api/src/wiring/createErrorCollector.ts index 633febd945..93540cec63 100644 --- a/packages/frontend-app-api/src/wiring/createErrorCollector.ts +++ b/packages/frontend-app-api/src/wiring/createErrorCollector.ts @@ -89,7 +89,7 @@ export interface ErrorCollector { AppErrorTypes[TCode]['context'], keyof TContext > extends infer IContext extends {} - ? [{}] extends [IContext] + ? {} extends IContext ? { code: TCode; message: string; diff --git a/packages/frontend-defaults/src/maybeCreateErrorPage.tsx b/packages/frontend-defaults/src/maybeCreateErrorPage.tsx index c4bce8cf73..40da64e987 100644 --- a/packages/frontend-defaults/src/maybeCreateErrorPage.tsx +++ b/packages/frontend-defaults/src/maybeCreateErrorPage.tsx @@ -16,8 +16,6 @@ import { FrontendPluginInfo } from '@backstage/frontend-plugin-api'; import { JSX, useEffect, useState } from 'react'; -// eslint-disable-next-line @backstage/no-relative-monorepo-imports -// eslint-disable-next-line @backstage/no-relative-monorepo-imports import { AppError, AppErrorTypes } from '@backstage/frontend-app-api'; const DEFAULT_WARNING_CODES: Array = [