address feedback

Signed-off-by: williamwu-mongodb <william.t.wu@mongodb.com>
This commit is contained in:
williamwu-mongodb
2025-12-09 12:05:21 -08:00
parent ef961b2299
commit c89d74b763
13 changed files with 173 additions and 88 deletions
+24
View File
@@ -0,0 +1,24 @@
/*
* Copyright 2025 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export {
devToolsTaskSchedulerReadPermission,
devToolsTaskSchedulerCreatePermission,
} from './permissions';
export type {
ScheduledTasks,
TaskApiTasksResponse,
TriggerScheduledTask,
} from './types';
+16 -2
View File
@@ -20,5 +20,19 @@
* @packageDocumentation
*/
export * from './types';
export * from './permissions';
export type {
ConfigError,
ConfigInfo,
DevToolsInfo,
Endpoint,
ExternalDependency,
PackageDependency,
} from './types';
export { ExternalDependencyStatus } from './types';
export {
devToolsAdministerPermission,
devToolsConfigReadPermission,
devToolsExternalDependenciesReadPermission,
devToolsInfoReadPermission,
devToolsPermissions,
} from './permissions';
+2 -4
View File
@@ -49,7 +49,7 @@ export const devToolsExternalDependenciesReadPermission = createPermission({
});
/**
* @public
* @alpha
*/
export const devToolsTaskSchedulerReadPermission = createPermission({
name: 'devtools.task-scheduler',
@@ -57,7 +57,7 @@ export const devToolsTaskSchedulerReadPermission = createPermission({
});
/**
* @public
* @alpha
*/
export const devToolsTaskSchedulerCreatePermission = createPermission({
name: 'devtools.task-scheduler',
@@ -74,6 +74,4 @@ export const devToolsPermissions = [
devToolsInfoReadPermission,
devToolsConfigReadPermission,
devToolsExternalDependenciesReadPermission,
devToolsTaskSchedulerReadPermission,
devToolsTaskSchedulerCreatePermission,
];
+3 -3
View File
@@ -88,7 +88,7 @@ export type ConfigError = {
* This is a duplication of the below:
* @see https://github.com/backstage/backstage/blob/master/packages/backend-defaults/src/entrypoints/scheduler/lib/types.ts
*
* @public
* @alpha
*/
export interface TaskApiTasksResponse {
taskId: string;
@@ -123,13 +123,13 @@ export interface TaskApiTasksResponse {
| null;
}
/** @public */
/** @alpha */
export type ScheduledTasks = {
scheduledTasks?: TaskApiTasksResponse[];
error?: string;
};
/** @public */
/** @alpha */
export type TriggerScheduledTask = {
error?: string;
};