From 0b7fd7a9d73b2bfc88819058c4b8db73903aa615 Mon Sep 17 00:00:00 2001 From: James Turley Date: Fri, 9 Apr 2021 10:30:30 +0100 Subject: [PATCH] Fix pull request sample template A null reference survived an earlier implementation. Signed-off-by: James Turley --- .changeset/witty-rats-bake.md | 5 +++++ .../sample-templates/pull-request/template.yaml | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changeset/witty-rats-bake.md diff --git a/.changeset/witty-rats-bake.md b/.changeset/witty-rats-bake.md new file mode 100644 index 0000000000..2189961899 --- /dev/null +++ b/.changeset/witty-rats-bake.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder-backend': patch +--- + +Fix bug in pull request sample template. diff --git a/plugins/scaffolder-backend/sample-templates/pull-request/template.yaml b/plugins/scaffolder-backend/sample-templates/pull-request/template.yaml index cad2a58d1f..b6de1c29ca 100644 --- a/plugins/scaffolder-backend/sample-templates/pull-request/template.yaml +++ b/plugins/scaffolder-backend/sample-templates/pull-request/template.yaml @@ -69,8 +69,9 @@ spec: {{#if parameters.description}} {{parameters.description}} {{/if}} - host: '{{parameters.host}}' targetPath: '{{#if parameters.targetPath}}{{parameters.targetPath}}{{else}}{{parameters.name}}{{/if}}' output: - remoteUrl: '{{steps.publish.output.remoteUrl}}' + links: + - url: '{{steps.publish.output.remoteUrl}}' + text: 'Go to PR'