From c8764b7fd7212541dc3cb1513b94750ad771fc88 Mon Sep 17 00:00:00 2001 From: Jonah Back Date: Tue, 21 Jun 2022 15:40:04 -0700 Subject: [PATCH] address a few code review comments Signed-off-by: Jonah Back --- .changeset/plenty-books-peel.md | 12 +++++++++++- .../src/processors/AwsEKSClusterProcessor.test.ts | 2 +- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.changeset/plenty-books-peel.md b/.changeset/plenty-books-peel.md index 6efd32bc36..3f8e25c943 100644 --- a/.changeset/plenty-books-peel.md +++ b/.changeset/plenty-books-peel.md @@ -1,6 +1,16 @@ --- -'@backstage/plugin-catalog-backend-module-aws': minor '@backstage/plugin-kubernetes-backend': minor --- Add support for Kubernetes clusters in the catalog. + +The KubernetesBuilder.createBuilder method now requires an additional field, +discovery. To update your backend, you will want to do something like the following: + +```javascript +KubernetesBuilder.createBuilder({ + config: env.config, + logger: env.config, + discovery: env.discovery, + }) +``` diff --git a/plugins/catalog-backend-module-aws/src/processors/AwsEKSClusterProcessor.test.ts b/plugins/catalog-backend-module-aws/src/processors/AwsEKSClusterProcessor.test.ts index 19730a674e..fc44f5f912 100644 --- a/plugins/catalog-backend-module-aws/src/processors/AwsEKSClusterProcessor.test.ts +++ b/plugins/catalog-backend-module-aws/src/processors/AwsEKSClusterProcessor.test.ts @@ -18,7 +18,7 @@ import { AwsEKSClusterProcessor } from './AwsEKSClusterProcessor'; import AWSMock from 'aws-sdk-mock'; import aws from 'aws-sdk'; -describe('AwsOrganizationCloudAccountProcessor', () => { +describe('AwsEKSClusterProcessor', () => { AWSMock.setSDKInstance(aws); describe('readLocation', () => { const processor = new (AwsEKSClusterProcessor as any)();