From c7f2a2307de7081da3f2d82fdd813ecc8d3f9a5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Bonnet?= Date: Fri, 1 Oct 2021 00:41:13 +0200 Subject: [PATCH] Remove `-backend` suffix from backend plugin ids MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Frédéric Bonnet --- .changeset/eleven-socks-hear.md | 5 +++++ packages/cli/src/commands/create-plugin/createPlugin.ts | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 .changeset/eleven-socks-hear.md diff --git a/.changeset/eleven-socks-hear.md b/.changeset/eleven-socks-hear.md new file mode 100644 index 0000000000..6551d1c95e --- /dev/null +++ b/.changeset/eleven-socks-hear.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +When creating a backend plugin with `--backend` flag, warn when the given plugin id already ends with `-backend` suffix diff --git a/packages/cli/src/commands/create-plugin/createPlugin.ts b/packages/cli/src/commands/create-plugin/createPlugin.ts index 0d47df8c22..6ddd1f7160 100644 --- a/packages/cli/src/commands/create-plugin/createPlugin.ts +++ b/packages/cli/src/commands/create-plugin/createPlugin.ts @@ -239,7 +239,10 @@ export default async (cmd: Command) => { } const answers: Answers = await inquirer.prompt(questions); - const pluginId = cmd.backend ? `${answers.id}-backend` : answers.id; + const pluginId = + cmd.backend && !answers.id.endsWith('-backend') + ? `${answers.id}-backend` + : answers.id; const name = cmd.scope ? `@${cmd.scope.replace(/^@/, '')}/plugin-${pluginId}`