From 161114feab43966d0ba593da81a33da3a0b0f4b8 Mon Sep 17 00:00:00 2001 From: Aditya Kumar Date: Wed, 13 Mar 2024 10:22:23 +0530 Subject: [PATCH] Added Material UI 4 import rule to plugins/apache-airflow Signed-off-by: Aditya Kumar --- .changeset/big-dancers-deliver.md | 5 +++++ plugins/apache-airflow/.eslintrc.js | 6 +++++- .../src/components/HomePage/HomePage.tsx | 2 +- .../LatestDagRunsStatus.tsx | 20 +++++++++---------- 4 files changed, 20 insertions(+), 13 deletions(-) create mode 100644 .changeset/big-dancers-deliver.md diff --git a/.changeset/big-dancers-deliver.md b/.changeset/big-dancers-deliver.md new file mode 100644 index 0000000000..729f3109a8 --- /dev/null +++ b/.changeset/big-dancers-deliver.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-apache-airflow': patch +--- + +added an optional ESLint rule - no-top-level-material-ui-4-imports - which has an auto fix function to migrate the imports and used it to migrate the imports for plugins/apache-airflow diff --git a/plugins/apache-airflow/.eslintrc.js b/plugins/apache-airflow/.eslintrc.js index e2a53a6ad2..9d5b45a010 100644 --- a/plugins/apache-airflow/.eslintrc.js +++ b/plugins/apache-airflow/.eslintrc.js @@ -1 +1,5 @@ -module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { + rules: { + '@backstage/no-top-level-material-ui-4-imports': 'error', + }, + }); \ No newline at end of file diff --git a/plugins/apache-airflow/src/components/HomePage/HomePage.tsx b/plugins/apache-airflow/src/components/HomePage/HomePage.tsx index 442f1bf4a0..9e988df198 100644 --- a/plugins/apache-airflow/src/components/HomePage/HomePage.tsx +++ b/plugins/apache-airflow/src/components/HomePage/HomePage.tsx @@ -22,7 +22,7 @@ import { Page, SupportButton, } from '@backstage/core-components'; -import { Grid } from '@material-ui/core'; +import Grid from '@material-ui/core/Grid'; import React from 'react'; import { DagTableComponent } from '../DagTableComponent'; import { StatusComponent } from '../StatusComponent'; diff --git a/plugins/apache-airflow/src/components/LatestDagRunsStatus/LatestDagRunsStatus.tsx b/plugins/apache-airflow/src/components/LatestDagRunsStatus/LatestDagRunsStatus.tsx index 90cb0694f8..d243f48e8a 100644 --- a/plugins/apache-airflow/src/components/LatestDagRunsStatus/LatestDagRunsStatus.tsx +++ b/plugins/apache-airflow/src/components/LatestDagRunsStatus/LatestDagRunsStatus.tsx @@ -18,17 +18,15 @@ import { apacheAirflowApiRef } from '../../api'; import useAsync from 'react-use/lib/useAsync'; import { DagRun } from '../../api/types/Dags'; import { useApi } from '@backstage/core-plugin-api'; -import { - Box, - Button, - CircularProgress, - List, - ListItem, - ListItemIcon, - makeStyles, - Tooltip, - Typography, -} from '@material-ui/core'; +import Box from '@material-ui/core/Box'; +import Button from '@material-ui/core/Button'; +import CircularProgress from '@material-ui/core/CircularProgress'; +import List from '@material-ui/core/List'; +import ListItem from '@material-ui/core/ListItem'; +import ListItemIcon from '@material-ui/core/ListItemIcon'; +import Tooltip from '@material-ui/core/Tooltip'; +import Typography from '@material-ui/core/Typography'; +import { makeStyles } from '@material-ui/core/styles'; import { Link, StatusError,