From c724eaa902c88a02e3d04617fe1dba1e8c9bc26f Mon Sep 17 00:00:00 2001 From: Jamal Sebbari Date: Thu, 18 Dec 2025 13:20:22 +0100 Subject: [PATCH] fix(puppetdb): handle undefined latest_report_status in transformer Fixes #25224 The defaultResourceTransformer crashes when latest_report_status is undefined because it's not present in /factsets endpoint response (only in /nodes). This adds optional chaining (?.) to safely handle undefined values. Signed-off-by: Jamal Sebbari --- .../src/puppet/transformers.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/plugins/catalog-backend-module-puppetdb/src/puppet/transformers.ts b/plugins/catalog-backend-module-puppetdb/src/puppet/transformers.ts index 5394041724..fac3771279 100644 --- a/plugins/catalog-backend-module-puppetdb/src/puppet/transformers.ts +++ b/plugins/catalog-backend-module-puppetdb/src/puppet/transformers.ts @@ -51,12 +51,10 @@ export const defaultResourceTransformer: ResourceTransformer = async ( description: node.facts?.data ?.find(e => e.name === 'ipaddress') ?.value?.toString(), - tags: kernel - ? [ - kernel.toString().toLocaleLowerCase('en-US'), - latest_report_status.toString().toLocaleLowerCase('en-US'), - ] - : [], + tags: [ + kernel?.toString().toLocaleLowerCase('en-US'), + latest_report_status?.toString().toLocaleLowerCase('en-US'), + ].filter((tag): tag is string => Boolean(tag)), }, spec: { type: type,