From c4473a314bc3c97ef74eae76517d1cf2473edd2d Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 1 Feb 2024 18:13:37 +0100 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Fredrik Adelöw Signed-off-by: Patrik Oldsberg --- beps/0003-auth-architecture-evolution/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/beps/0003-auth-architecture-evolution/README.md b/beps/0003-auth-architecture-evolution/README.md index 4089211fb9..60d5eb74a5 100644 --- a/beps/0003-auth-architecture-evolution/README.md +++ b/beps/0003-auth-architecture-evolution/README.md @@ -268,7 +268,7 @@ router.get('/read-data', (req, res) => { #### Issuing a cookie and allowing user cookie auth on a separate endpoint ```ts -router.get('/cookie', (req, res) => { +router.get('/cookie', async (req, res) => { await httpAuth.issueUserCookie(res); // If this is a service call it'll throw res.json({ ok: true }); }); @@ -293,7 +293,7 @@ router.get( httpAuth.middleware({ allow: ['user-cookie'] }), (req, res) => { // These credentials don't actually contain an underlying user token for cookie-authed requests - // You you try to pass them to the AuthService, it'll throw. + // If you try to pass them to the AuthService, it'll throw. const { user } = httpAuth.credentials(req); console.log( `User ref=${user.userEntityRef} ownership=${user.ownershipEntityRefs}`,