diff --git a/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.test.tsx b/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.test.tsx index bb7faabc9d..df179ca219 100644 --- a/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.test.tsx +++ b/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.test.tsx @@ -41,7 +41,9 @@ describe('RegisterComponentForm', () => { ), ).toBeInTheDocument(); - const submit = (await rendered.getByRole('button')) as HTMLButtonElement; + const submit = (await rendered.getByTestId( + 'registerComponentFormSubmit', + )) as HTMLButtonElement; expect(submit.disabled).toBeTruthy(); }); @@ -54,7 +56,9 @@ describe('RegisterComponentForm', () => { target: { value: 'https://example.com/blob/master/component.yaml' }, }); }); - const submit = (await rendered.getByRole('button')) as HTMLButtonElement; + const submit = (await rendered.getByTestId( + 'registerComponentFormSubmit', + )) as HTMLButtonElement; expect(submit.disabled).toBeFalsy(); }); diff --git a/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.tsx b/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.tsx index 4090b2af9c..294f4db801 100644 --- a/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.tsx +++ b/plugins/register-component/src/components/RegisterComponentForm/RegisterComponentForm.tsx @@ -21,10 +21,13 @@ import { FormHelperText, LinearProgress, TextField, + Select, + MenuItem, + InputLabel, } from '@material-ui/core'; import { makeStyles } from '@material-ui/core/styles'; import React, { FC } from 'react'; -import { useForm } from 'react-hook-form'; +import { useForm, Controller } from 'react-hook-form'; import { ComponentIdValidators } from '../../util/validate'; const useStyles = makeStyles(theme => ({ @@ -44,7 +47,7 @@ export type Props = { }; const RegisterComponentForm: FC = ({ onSubmit, submitting }) => { - const { register, handleSubmit, errors, formState } = useForm({ + const { control, register, handleSubmit, errors, formState } = useForm({ mode: 'onChange', }); const classes = useStyles(); @@ -84,8 +87,33 @@ const RegisterComponentForm: FC = ({ onSubmit, submitting }) => { )} + + + SCM Detection + ( + + )} + /> +