From 2e1f8941fe59b68b01a043d23666899529299299 Mon Sep 17 00:00:00 2001 From: Gowind Date: Tue, 9 Feb 2021 18:18:10 +0100 Subject: [PATCH 1/2] Pass registered Logger in ServiceBuilderImpl to requestLoggingHandler `requestLoggingHandler` takes an optional `logger` parameter that it can use to log incoming requests. The `ServiceBuilderImpl` was not passing on this logger, if set, to `requestLoggingHandler` middleware --- packages/backend-common/src/service/lib/ServiceBuilderImpl.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts b/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts index 9c5ac20fa3..07da975184 100644 --- a/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts +++ b/packages/backend-common/src/service/lib/ServiceBuilderImpl.ts @@ -161,7 +161,7 @@ export class ServiceBuilderImpl implements ServiceBuilder { app.use(cors(corsOptions)); } app.use(compression()); - app.use(requestLoggingHandler()); + app.use(requestLoggingHandler(logger)); for (const [root, route] of this.routers) { app.use(root, route); } From 16fb1d03a3b898577b634d1184f374ee7937447b Mon Sep 17 00:00:00 2001 From: Gowind Date: Thu, 11 Feb 2021 22:27:26 +0100 Subject: [PATCH 2/2] Add changeset for fixing requestLoggingHandler --- .changeset/afraid-dingos-own.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/afraid-dingos-own.md diff --git a/.changeset/afraid-dingos-own.md b/.changeset/afraid-dingos-own.md new file mode 100644 index 0000000000..9f7010d330 --- /dev/null +++ b/.changeset/afraid-dingos-own.md @@ -0,0 +1,5 @@ +--- +'@backstage/backend-common': patch +--- + +pass registered logger to requestLoggingHandler