From b63b3108a51c9d8478498fbd7bb2eebfda5d1938 Mon Sep 17 00:00:00 2001 From: kim5566 <28945404+kim5566@users.noreply.github.com> Date: Mon, 25 Apr 2022 06:23:44 +1000 Subject: [PATCH 1/4] fix: btoa encoding Signed-off-by: kim5566 <28945404+kim5566@users.noreply.github.com> --- plugins/techdocs/src/reader/transformers/addBaseUrl.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/techdocs/src/reader/transformers/addBaseUrl.ts b/plugins/techdocs/src/reader/transformers/addBaseUrl.ts index 2e3b853e42..96a5888a2a 100644 --- a/plugins/techdocs/src/reader/transformers/addBaseUrl.ts +++ b/plugins/techdocs/src/reader/transformers/addBaseUrl.ts @@ -69,7 +69,9 @@ export const addBaseUrl = ({ const svgContent = await svg.text(); elem.setAttribute( attributeName, - `data:image/svg+xml;base64,${btoa(svgContent)}`, + `data:image/svg+xml;base64,${btoa( + unescape(encodeURIComponent(svgContent)), + )}`, ); } catch (e) { elem.setAttribute('alt', `Error: ${elemAttribute}`); From bbe09df689a76b00f17116c7c68d893c1627852e Mon Sep 17 00:00:00 2001 From: kim5566 <28945404+kim5566@users.noreply.github.com> Date: Mon, 25 Apr 2022 06:35:04 +1000 Subject: [PATCH 2/4] add changeset Signed-off-by: kim5566 <28945404+kim5566@users.noreply.github.com> --- .changeset/hot-berries-collect.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/hot-berries-collect.md diff --git a/.changeset/hot-berries-collect.md b/.changeset/hot-berries-collect.md new file mode 100644 index 0000000000..d4e6ad7599 --- /dev/null +++ b/.changeset/hot-berries-collect.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-techdocs': patch +--- + +Loading SVGs correctly with bota with extended characters From 22b5f885a25d86b0169ce2f8a1f8ba820913d581 Mon Sep 17 00:00:00 2001 From: kim5566 <28945404+kim5566@users.noreply.github.com> Date: Mon, 25 Apr 2022 06:40:35 +1000 Subject: [PATCH 3/4] update changeset Signed-off-by: kim5566 <28945404+kim5566@users.noreply.github.com> --- .changeset/hot-berries-collect.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/hot-berries-collect.md b/.changeset/hot-berries-collect.md index d4e6ad7599..efb8dcc7c9 100644 --- a/.changeset/hot-berries-collect.md +++ b/.changeset/hot-berries-collect.md @@ -2,4 +2,4 @@ '@backstage/plugin-techdocs': patch --- -Loading SVGs correctly with bota with extended characters +Loading SVGs correctly with `bota` with extended characters From 2dcb2c9678823be0691805ec94b2d5eb37f7495d Mon Sep 17 00:00:00 2001 From: kim5566 <28945404+kim5566@users.noreply.github.com> Date: Tue, 10 May 2022 07:27:29 +1000 Subject: [PATCH 4/4] rename changeset Signed-off-by: kim5566 <28945404+kim5566@users.noreply.github.com> --- .../{hot-berries-collect.md => techdocs-hot-berries-collect.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .changeset/{hot-berries-collect.md => techdocs-hot-berries-collect.md} (100%) diff --git a/.changeset/hot-berries-collect.md b/.changeset/techdocs-hot-berries-collect.md similarity index 100% rename from .changeset/hot-berries-collect.md rename to .changeset/techdocs-hot-berries-collect.md