From c38610bd9dcd939a59c03aea03d60e70d618e916 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Sat, 28 Mar 2026 17:07:00 +0100 Subject: [PATCH] Address review feedback: add cast rationale, drop redundant assertError MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Opus 4.6 (1M context) Signed-off-by: Fredrik Adelöw --- .../implementations/FetchApi/ClarifyFailuresFetchMiddleware.ts | 2 ++ packages/frontend-app-api/src/wiring/predicates.ts | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/core-app-api/src/apis/implementations/FetchApi/ClarifyFailuresFetchMiddleware.ts b/packages/core-app-api/src/apis/implementations/FetchApi/ClarifyFailuresFetchMiddleware.ts index cee9b902aa..46985bb244 100644 --- a/packages/core-app-api/src/apis/implementations/FetchApi/ClarifyFailuresFetchMiddleware.ts +++ b/packages/core-app-api/src/apis/implementations/FetchApi/ClarifyFailuresFetchMiddleware.ts @@ -24,6 +24,8 @@ export class ClarifyFailuresFetchMiddleware implements FetchMiddleware { apply(next: typeof fetch): typeof fetch { return async (input, init) => { try { + // NOTE: The "as any" cast is because of subtle undici type differences + // that happened in a node types bump. Immaterial at runtime. return await next(input as any, init); } catch (e) { if (e instanceof TypeError && e.message === 'Failed to fetch') { diff --git a/packages/frontend-app-api/src/wiring/predicates.ts b/packages/frontend-app-api/src/wiring/predicates.ts index f0a91814ee..4321b869c8 100644 --- a/packages/frontend-app-api/src/wiring/predicates.ts +++ b/packages/frontend-app-api/src/wiring/predicates.ts @@ -24,7 +24,7 @@ import type { EvaluatePermissionRequest, EvaluatePermissionResponse, } from '@backstage/plugin-permission-common'; -import { assertError, ForwardedError } from '@backstage/errors'; +import { ForwardedError } from '@backstage/errors'; export type ExtensionPredicateContext = { featureFlags: string[]; @@ -98,7 +98,6 @@ export function createPredicateContextLoader(options: { (_, i) => responses[i].result === 'ALLOW', ); } catch (error) { - assertError(error); throw new ForwardedError( 'Failed to authorize extension permissions', error,