backend-plugin-api: move BackendFactory to common types

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>

packages/backend-plugin-api/src/index.ts

@@ -21,4 +21,5 @@
  */
 
 export * from './services';
+export type { BackendFeature } from './types';
 export * from './wiring';

packages/backend-plugin-api/src/services/system/index.ts

@@ -15,7 +15,6 @@
  */
 
 export type {
-  BackendFeature,
   ServiceRef,
   ServiceRefConfig,
   ServiceFactory,

packages/backend-plugin-api/src/services/system/types.ts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+import { BackendFeature } from '../../types';
+
 /**
  * TODO
  *
@@ -85,20 +87,6 @@ export interface ServiceRefConfig<TService, TScope extends 'root' | 'plugin'> {
   ) => Promise<ServiceFactoryOrFunction>;
 }
 
-/** @internal */
-export interface BackendFeatureFactory<
-  TOptions extends [options?: object] = [],
-> {
-  (...options: TOptions): BackendFeature;
-  $$type: '@backstage/BackendFeatureFactory';
-}
-
-/** @public */
-export interface BackendFeature {
-  // NOTE: This type is opaque in order to simplify future API evolution.
-  $$type: '@backstage/BackendFeature';
-}
-
 /**
  * Creates a new service definition. This overload is used to create plugin scoped services.
  *

packages/backend-plugin-api/src/types.ts

@@ -0,0 +1,29 @@
+/*
+ * Copyright 2023 The Backstage Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/** @internal */
+export interface BackendFeatureFactory<
+  TOptions extends [options?: object] = [],
+> {
+  (...options: TOptions): BackendFeature;
+  $$type: '@backstage/BackendFeatureFactory';
+}
+
+/** @public */
+export interface BackendFeature {
+  // NOTE: This type is opaque in order to simplify future API evolution.
+  $$type: '@backstage/BackendFeature';
+}

packages/backend-plugin-api/src/wiring/factories.ts

@@ -14,10 +14,7 @@
  * limitations under the License.
  */
 
-import {
-  BackendFeature,
-  BackendFeatureFactory,
-} from '../services/system/types';
+import { BackendFeature, BackendFeatureFactory } from '../types';
 import {
   BackendModuleRegistrationPoints,
   BackendPluginRegistrationPoints,

packages/backend-plugin-api/src/wiring/types.ts

@@ -14,7 +14,8 @@
  * limitations under the License.
  */
 
-import { BackendFeature, ServiceRef } from '../services/system/types';
+import { ServiceRef } from '../services/system/types';
+import { BackendFeature } from '../types';
 
 /**
  * TODO