diff --git a/.changeset/gentle-walls-invent.md b/.changeset/gentle-walls-invent.md new file mode 100644 index 0000000000..82469df6d3 --- /dev/null +++ b/.changeset/gentle-walls-invent.md @@ -0,0 +1,6 @@ +--- +'@backstage/plugin-scaffolder-react': patch +'@backstage/plugin-scaffolder': patch +--- + +Accessibility issues identified using lighthouse fixed. diff --git a/plugins/scaffolder-react/src/next/components/ScaffolderPageContextMenu/ScaffolderPageContextMenu.tsx b/plugins/scaffolder-react/src/next/components/ScaffolderPageContextMenu/ScaffolderPageContextMenu.tsx index fc3c0249a0..7ccbe4ef8d 100644 --- a/plugins/scaffolder-react/src/next/components/ScaffolderPageContextMenu/ScaffolderPageContextMenu.tsx +++ b/plugins/scaffolder-react/src/next/components/ScaffolderPageContextMenu/ScaffolderPageContextMenu.tsx @@ -68,9 +68,12 @@ export function ScaffolderPageContextMenu( return ( <> { return ( - Categories + + Categories + setSelectedTypes(value)} diff --git a/plugins/scaffolder/src/components/ActionsPage/ActionsPage.tsx b/plugins/scaffolder/src/components/ActionsPage/ActionsPage.tsx index 3f21b75322..5e7f9810c5 100644 --- a/plugins/scaffolder/src/components/ActionsPage/ActionsPage.tsx +++ b/plugins/scaffolder/src/components/ActionsPage/ActionsPage.tsx @@ -251,7 +251,9 @@ export const ActionsPage = () => { return ( <> - {name} + + {name} + {input.map((i, index) => (
{renderTable( @@ -275,13 +277,15 @@ export const ActionsPage = () => { ); return ( - + {action.id} {action.description && } {action.schema?.input && ( - Input + + Input + {renderTable( formatRows(`${action.id}.input`, action?.schema?.input), )} @@ -290,7 +294,9 @@ export const ActionsPage = () => { )} {action.schema?.output && ( - Output + + Output + {renderTable( formatRows(`${action.id}.output`, action?.schema?.output), )} @@ -299,7 +305,9 @@ export const ActionsPage = () => { {action.examples && ( }> - Examples + + Examples + diff --git a/plugins/scaffolder/src/components/ListTasksPage/OwnerListPicker.tsx b/plugins/scaffolder/src/components/ListTasksPage/OwnerListPicker.tsx index a9e3917922..ee383569ee 100644 --- a/plugins/scaffolder/src/components/ListTasksPage/OwnerListPicker.tsx +++ b/plugins/scaffolder/src/components/ListTasksPage/OwnerListPicker.tsx @@ -99,16 +99,21 @@ export const OwnerListPicker = (props: { {filterGroups.map(group => ( - + {group.name} - + {group.items.map(item => ( onSelectOwner(item.id as 'owned' | 'all')} selected={item.id === filter} className={classes.menuItem} diff --git a/plugins/scaffolder/src/components/MultistepJsonForm/MultistepJsonForm.tsx b/plugins/scaffolder/src/components/MultistepJsonForm/MultistepJsonForm.tsx index 0924c4f2e6..ec95bad0e5 100644 --- a/plugins/scaffolder/src/components/MultistepJsonForm/MultistepJsonForm.tsx +++ b/plugins/scaffolder/src/components/MultistepJsonForm/MultistepJsonForm.tsx @@ -172,7 +172,7 @@ export const MultistepJsonForm = (props: MultistepJsonFormProps) => { aria-disabled="false" tabIndex={0} > - + {title} diff --git a/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPageContextMenu.tsx b/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPageContextMenu.tsx index ef79eda406..5558b314da 100644 --- a/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPageContextMenu.tsx +++ b/plugins/scaffolder/src/components/ScaffolderPage/ScaffolderPageContextMenu.tsx @@ -77,9 +77,12 @@ export function ScaffolderPageContextMenu( return ( <> - +
diff --git a/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditorIntro.tsx b/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditorIntro.tsx index 61e6c46964..2a75c1bf2c 100644 --- a/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditorIntro.tsx +++ b/plugins/scaffolder/src/components/TemplateEditorPage/TemplateEditorIntro.tsx @@ -59,7 +59,8 @@ export function TemplateEditorIntro(props: EditorIntroProps) { > props.onSelect?.('form')}> - + Edit Template Form @@ -108,7 +109,7 @@ export function TemplateEditorIntro(props: EditorIntroProps) { props.onSelect?.('field-explorer')}> - + Custom Field Explorer @@ -122,7 +123,7 @@ export function TemplateEditorIntro(props: EditorIntroProps) { return (
- + Get started by choosing one of the options below
- +
diff --git a/plugins/scaffolder/src/components/TemplateTypePicker/TemplateTypePicker.tsx b/plugins/scaffolder/src/components/TemplateTypePicker/TemplateTypePicker.tsx index e7c2c965f2..88ddef2b92 100644 --- a/plugins/scaffolder/src/components/TemplateTypePicker/TemplateTypePicker.tsx +++ b/plugins/scaffolder/src/components/TemplateTypePicker/TemplateTypePicker.tsx @@ -58,10 +58,16 @@ export const TemplateTypePicker = () => { return ( - Categories + + Categories + setSelectedTypes(value)} diff --git a/plugins/scaffolder/src/next/TemplateEditorPage/CustomFieldExplorer.tsx b/plugins/scaffolder/src/next/TemplateEditorPage/CustomFieldExplorer.tsx index 823d5b164a..bf5ffe97ea 100644 --- a/plugins/scaffolder/src/next/TemplateEditorPage/CustomFieldExplorer.tsx +++ b/plugins/scaffolder/src/next/TemplateEditorPage/CustomFieldExplorer.tsx @@ -140,7 +140,7 @@ export const CustomFieldExplorer = ({ - +