From 3a90dc9176eb8ab3673e468eee733616384f9e76 Mon Sep 17 00:00:00 2001 From: Brian Forbis Date: Fri, 26 May 2023 10:29:21 -0400 Subject: [PATCH 1/3] Fix config visibility for ga4 Signed-off-by: Brian Forbis --- plugins/analytics-module-ga4/config.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/analytics-module-ga4/config.d.ts b/plugins/analytics-module-ga4/config.d.ts index d90ccb5938..4834d75f58 100644 --- a/plugins/analytics-module-ga4/config.d.ts +++ b/plugins/analytics-module-ga4/config.d.ts @@ -80,14 +80,14 @@ export interface Config { * metadata will be captured in Google Analytics. * Contexts that will be sent as parameters in the event. * context-name will be prefixed by c_, for example, pluginId will be c_pluginId in the event. - * + * @visibility frontend */ allowedContexts?: string[] | ['*']; /** * * Attributes that will be sent as parameters in the event * attribute-name will be prefixed by a_, for example , testAttribute will be c_testAttribute in the event. - * + * @visibility frontend */ allowedAttributes?: string[] | ['*']; }; From 99056db6169ef1ebe406ff9d8078c61839127ea1 Mon Sep 17 00:00:00 2001 From: Brian Forbis Date: Fri, 26 May 2023 10:32:15 -0400 Subject: [PATCH 2/3] Add changeset Signed-off-by: Brian Forbis --- .changeset/gentle-turtles-applaud.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/gentle-turtles-applaud.md diff --git a/.changeset/gentle-turtles-applaud.md b/.changeset/gentle-turtles-applaud.md new file mode 100644 index 0000000000..04d401245d --- /dev/null +++ b/.changeset/gentle-turtles-applaud.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-analytics-module-ga4': patch +--- + +Fixed configuration visibility settings for allowedContexts and allowedAttributes From 5ba78a7a3874aa9dd8320e6509d0599d9f64b326 Mon Sep 17 00:00:00 2001 From: bforbis Date: Mon, 29 May 2023 14:48:56 -0400 Subject: [PATCH 3/3] Update .changeset/gentle-turtles-applaud.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Fredrik Adelöw Signed-off-by: bforbis --- .changeset/gentle-turtles-applaud.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/gentle-turtles-applaud.md b/.changeset/gentle-turtles-applaud.md index 04d401245d..f05d8b156c 100644 --- a/.changeset/gentle-turtles-applaud.md +++ b/.changeset/gentle-turtles-applaud.md @@ -2,4 +2,4 @@ '@backstage/plugin-analytics-module-ga4': patch --- -Fixed configuration visibility settings for allowedContexts and allowedAttributes +Fixed configuration visibility settings for `allowedContexts` and `allowedAttributes`