From c58f8264f1d646faaf97ebd6647ec5a9d19df553 Mon Sep 17 00:00:00 2001 From: Markus Date: Thu, 12 Oct 2023 17:55:27 +0200 Subject: [PATCH 1/2] fix: empty scope in oidc client response Signed-off-by: Markus --- plugins/auth-backend/src/providers/oidc/provider.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/auth-backend/src/providers/oidc/provider.ts b/plugins/auth-backend/src/providers/oidc/provider.ts index 7638027b01..b6608aebbd 100644 --- a/plugins/auth-backend/src/providers/oidc/provider.ts +++ b/plugins/auth-backend/src/providers/oidc/provider.ts @@ -130,6 +130,9 @@ export class OidcAuthProvider implements OAuthHandlers { if (!tokenset.access_token) { throw new Error('Refresh failed'); } + if (!tokenset.scope) { + tokenset.scope = req.scope; + } const userinfo = await client.userinfo(tokenset.access_token); return { From 9ff79351527bef6d09bd5cff9e4eb651c666cee2 Mon Sep 17 00:00:00 2001 From: Markus Date: Thu, 12 Oct 2023 18:16:04 +0200 Subject: [PATCH 2/2] chore: add changeset Signed-off-by: Markus --- .changeset/five-spiders-listen.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/five-spiders-listen.md diff --git a/.changeset/five-spiders-listen.md b/.changeset/five-spiders-listen.md new file mode 100644 index 0000000000..a7968964e2 --- /dev/null +++ b/.changeset/five-spiders-listen.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-auth-backend': patch +--- + +Fixed bug in oidc refresh handler, if token endpoints response on refresh request does not contain a scope, the requested scope is used.