From c1a7704ad1370dd1e9288be961bcbc61692c54a1 Mon Sep 17 00:00:00 2001
From: blam <ben@blam.sh>
Date: Wed, 19 May 2021 20:08:47 +0200
Subject: [PATCH] chore: add deprecation warning when using v1 templates

Signed-off-by: blam <ben@blam.sh>
---
 .../scaffolder-backend/src/service/router.ts  | 133 +-----------------
 1 file changed, 4 insertions(+), 129 deletions(-)

diff --git a/plugins/scaffolder-backend/src/service/router.ts b/plugins/scaffolder-backend/src/service/router.ts
index 5e0790526e..0a38517c4a 100644
--- a/plugins/scaffolder-backend/src/service/router.ts
+++ b/plugins/scaffolder-backend/src/service/router.ts
@@ -137,134 +137,6 @@ export async function createRouter(
 
   worker.start();
 
-  router
-    .get('/v1/job/:jobId', ({ params }, res) => {
-      const job = jobProcessor.get(params.jobId);
-
-      if (!job) {
-        res.status(404).json({ error: 'job not found' });
-        return;
-      }
-
-      res.json({
-        id: job.id,
-        metadata: {
-          ...job.context,
-          logger: undefined,
-          logStream: undefined,
-        },
-        status: job.status,
-        stages: job.stages.map(stage => ({
-          ...stage,
-          handler: undefined,
-        })),
-        error: job.error,
-      });
-    })
-    .post('/v1/jobs', async (req, res) => {
-      const templateName: string = req.body.templateName;
-      const values: TemplaterValues = {
-        ...req.body.values,
-        destination: {
-          git: parseGitUrl(req.body.values.storePath),
-        },
-      };
-
-      // Forward authorization from client
-      const template = await entityClient.findTemplate(templateName, {
-        token: getBearerToken(req.headers.authorization),
-      });
-      if (!isAlpha1Template(template)) {
-        throw new InputError(
-          `This endpoint does not support templates with version ${template.apiVersion}`,
-        );
-      }
-
-      const validationResult: ValidatorResult = validate(
-        values,
-        template.spec.schema,
-      );
-
-      if (!validationResult.valid) {
-        res.status(400).json({ errors: validationResult.errors });
-        return;
-      }
-
-      const job = jobProcessor.create({
-        entity: template,
-        values,
-        stages: [
-          {
-            name: 'Prepare the skeleton',
-            async handler(ctx) {
-              const {
-                protocol,
-                location: templateEntityLocation,
-              } = parseLocationAnnotation(ctx.entity);
-
-              if (protocol === 'file') {
-                const preparer = new FilePreparer();
-
-                const path = resolvePath(
-                  dirname(templateEntityLocation),
-                  template.spec.path || '.',
-                );
-
-                await preparer.prepare({
-                  url: `file://${path}`,
-                  logger: ctx.logger,
-                  workspacePath: ctx.workspacePath,
-                });
-                return;
-              }
-
-              const preparer = preparers.get(templateEntityLocation);
-
-              const url = joinGitUrlPath(
-                templateEntityLocation,
-                template.spec.path,
-              );
-
-              await preparer.prepare({
-                url,
-                logger: ctx.logger,
-                workspacePath: ctx.workspacePath,
-              });
-            },
-          },
-          {
-            name: 'Run the templater',
-            async handler(ctx) {
-              const templater = templaters.get(ctx.entity.spec.templater);
-              await templater.run({
-                workspacePath: ctx.workspacePath,
-                logStream: ctx.logStream,
-                values: ctx.values,
-              });
-            },
-          },
-          {
-            name: 'Publish template',
-            handler: async ctx => {
-              const publisher = publishers.get(ctx.values.storePath);
-              ctx.logger.info('Will now store the template');
-              const result = await publisher.publish({
-                values: ctx.values,
-                workspacePath: ctx.workspacePath,
-                logger: ctx.logger,
-              });
-              return result;
-            },
-          },
-        ],
-      });
-
-      jobProcessor.run(job);
-
-      res.status(201).json({ id: job.id });
-    });
-
-  // NOTE: The v2 API is unstable
   router
     .get(
       '/v2/templates/:namespace/:kind/:name/parameter-schema',
@@ -359,8 +231,11 @@ export async function createRouter(
 
       let taskSpec;
       if (isAlpha1Template(template)) {
-        const result = validate(values, template.spec.schema);
+        logger.warn(
+          `[DEPRECATION] - Template: ${template.metadata.name} has version ${template.apiVersion} which is going to be deprecated. Please refer to https://backstage.io/docs/features/software-templates/migrating-from-v1alpha1-to-v1beta2 for help on migrating`,
+        );
 
+        const result = validate(values, template.spec.schema);
         if (!result.valid) {
           res.status(400).json({ errors: result.errors });
           return;