From 027f7ff705f2f72c7ddb94adbb9c4a75daf2eb42 Mon Sep 17 00:00:00 2001 From: Scott Guymer Date: Wed, 28 Jun 2023 14:41:07 +0200 Subject: [PATCH 1/3] sonarqube: Make default config optional Signed-off-by: Scott Guymer --- plugins/sonarqube-backend/config.d.ts | 4 ++-- plugins/sonarqube/config.d.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/sonarqube-backend/config.d.ts b/plugins/sonarqube-backend/config.d.ts index ce5bc641b6..7e93f61eb4 100644 --- a/plugins/sonarqube-backend/config.d.ts +++ b/plugins/sonarqube-backend/config.d.ts @@ -21,13 +21,13 @@ export interface Config { * The base url of the sonarqube installation. Defaults to https://sonarcloud.io. * @visibility frontend */ - baseUrl: string; + baseUrl?: string; /** * The api key to access the sonarqube instance under baseUrl. * @visibility secret */ - apiKey: string; + apiKey?: string; /** * The optional sonarqube instances. diff --git a/plugins/sonarqube/config.d.ts b/plugins/sonarqube/config.d.ts index 5759e63f98..8ba989b02c 100644 --- a/plugins/sonarqube/config.d.ts +++ b/plugins/sonarqube/config.d.ts @@ -21,6 +21,6 @@ export interface Config { * The base url of the sonarqube installation. Defaults to https://sonarcloud.io. * @visibility frontend */ - baseUrl: string; + baseUrl?: string; }; } From fcaf4cfc70ee075f0bd53a50ec837712f301fc17 Mon Sep 17 00:00:00 2001 From: Scott Guymer Date: Wed, 28 Jun 2023 14:43:56 +0200 Subject: [PATCH 2/3] Added changeset Signed-off-by: Scott Guymer --- .changeset/mighty-pandas-deny.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/mighty-pandas-deny.md diff --git a/.changeset/mighty-pandas-deny.md b/.changeset/mighty-pandas-deny.md new file mode 100644 index 0000000000..381e76d52b --- /dev/null +++ b/.changeset/mighty-pandas-deny.md @@ -0,0 +1,6 @@ +--- +'@backstage/plugin-sonarqube': minor +'@backstage/plugin-sonarqube-backend': minor +--- + +Made default config optional From 8f0cc48d34cbb8eff5293a69d2edad79568dc527 Mon Sep 17 00:00:00 2001 From: Scott Guymer Date: Wed, 28 Jun 2023 19:41:47 +0200 Subject: [PATCH 3/3] Update .changeset/mighty-pandas-deny.md Signed-off-by: Scott Guymer --- .changeset/mighty-pandas-deny.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.changeset/mighty-pandas-deny.md b/.changeset/mighty-pandas-deny.md index 381e76d52b..8c18c46469 100644 --- a/.changeset/mighty-pandas-deny.md +++ b/.changeset/mighty-pandas-deny.md @@ -1,6 +1,6 @@ --- -'@backstage/plugin-sonarqube': minor -'@backstage/plugin-sonarqube-backend': minor +'@backstage/plugin-sonarqube': patch +'@backstage/plugin-sonarqube-backend': patch --- Made default config optional