From c11ab0f35b59ece809c7681fe9c3146e41428622 Mon Sep 17 00:00:00 2001 From: Johan Haals Date: Tue, 18 Oct 2022 14:16:06 +0200 Subject: [PATCH] chore: remove unused logger Signed-off-by: Johan Haals --- .../backend-common/src/reading/UrlReaderPredicateMux.test.ts | 5 ++--- packages/backend-common/src/reading/UrlReaderPredicateMux.ts | 3 --- packages/backend-common/src/reading/UrlReaders.ts | 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/packages/backend-common/src/reading/UrlReaderPredicateMux.test.ts b/packages/backend-common/src/reading/UrlReaderPredicateMux.test.ts index 028439365c..5a11e068df 100644 --- a/packages/backend-common/src/reading/UrlReaderPredicateMux.test.ts +++ b/packages/backend-common/src/reading/UrlReaderPredicateMux.test.ts @@ -14,7 +14,6 @@ * limitations under the License. */ -import { getVoidLogger } from '../logging'; import { UrlReaderPredicateMux } from './UrlReaderPredicateMux'; describe('UrlReaderPredicateMux', () => { @@ -32,7 +31,7 @@ describe('UrlReaderPredicateMux', () => { search: jest.fn(), }; - const mux = new UrlReaderPredicateMux(getVoidLogger()); + const mux = new UrlReaderPredicateMux(); mux.register({ predicate: url => url.hostname === 'foo', reader: fooReader, @@ -62,7 +61,7 @@ describe('UrlReaderPredicateMux', () => { }); it('throws an error if no predicate matches', async () => { - const mux = new UrlReaderPredicateMux(getVoidLogger()); + const mux = new UrlReaderPredicateMux(); await expect(mux.readUrl('http://foo/1')).rejects.toThrow( /^Reading from 'http:\/\/foo\/1' is not allowed. You may/, diff --git a/packages/backend-common/src/reading/UrlReaderPredicateMux.ts b/packages/backend-common/src/reading/UrlReaderPredicateMux.ts index 6e932d3cea..d5d30605b2 100644 --- a/packages/backend-common/src/reading/UrlReaderPredicateMux.ts +++ b/packages/backend-common/src/reading/UrlReaderPredicateMux.ts @@ -15,7 +15,6 @@ */ import { NotAllowedError } from '@backstage/errors'; -import { Logger } from 'winston'; import { ReadTreeOptions, ReadTreeResponse, @@ -42,8 +41,6 @@ function notAllowedMessage(url: string) { export class UrlReaderPredicateMux implements UrlReader { private readonly readers: UrlReaderPredicateTuple[] = []; - constructor(private readonly logger: Logger) {} - register(tuple: UrlReaderPredicateTuple): void { this.readers.push(tuple); } diff --git a/packages/backend-common/src/reading/UrlReaders.ts b/packages/backend-common/src/reading/UrlReaders.ts index 72833454c3..1e9d7ba5f4 100644 --- a/packages/backend-common/src/reading/UrlReaders.ts +++ b/packages/backend-common/src/reading/UrlReaders.ts @@ -55,7 +55,7 @@ export class UrlReaders { */ static create(options: UrlReadersOptions): UrlReader { const { logger, config, factories } = options; - const mux = new UrlReaderPredicateMux(logger); + const mux = new UrlReaderPredicateMux(); const treeResponseFactory = DefaultReadTreeResponseFactory.create({ config, });