From c0984b1402ddb4bbe386e8b819336f1cbf6bdab9 Mon Sep 17 00:00:00 2001 From: blam Date: Mon, 2 Aug 2021 18:03:41 +0200 Subject: [PATCH] chore: fixing up the typescript issue and fix up changeset description Signed-off-by: blam --- .changeset/purple-rocks-explode.md | 2 +- packages/integration/src/github/GithubCredentialsProvider.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.changeset/purple-rocks-explode.md b/.changeset/purple-rocks-explode.md index 4969a42a6b..86f575e317 100644 --- a/.changeset/purple-rocks-explode.md +++ b/.changeset/purple-rocks-explode.md @@ -2,4 +2,4 @@ '@backstage/integration': patch --- -Fixed bug on when compared in organzation name on github +Fixed bug for comparing Organization name in `GithubCredentialsProvider` diff --git a/packages/integration/src/github/GithubCredentialsProvider.ts b/packages/integration/src/github/GithubCredentialsProvider.ts index 36cb0ef14d..ba30900358 100644 --- a/packages/integration/src/github/GithubCredentialsProvider.ts +++ b/packages/integration/src/github/GithubCredentialsProvider.ts @@ -129,7 +129,7 @@ class GithubAppManager { private async getInstallationData(owner: string): Promise { const allInstallations = await this.getInstallations(); const installation = allInstallations.find( - inst => inst.account?.login.toLowerCase() === owner.toLowerCase(), + inst => inst.account?.login?.toLowerCase() === owner.toLowerCase(), ); if (installation) { return {