From c00488983cebaec0f67fbdeaee8f77e9fba4961a Mon Sep 17 00:00:00 2001
From: Andrew Thauer <6507159+andrewthauer@users.noreply.github.com>
Date: Mon, 11 Jan 2021 17:12:14 -0500
Subject: [PATCH] feat: enable catalog table actions for all location types

The edit button has had support for other providers for a while and there is
no specific reason the View in GitHub cannot work for all locations. This
change also replaces the GitHub icon with the OpenInNew icon.
---
 .changeset/red-baboons-rhyme.md                          | 9 +++++++++
 .../catalog/src/components/CatalogTable/CatalogTable.tsx | 8 +++-----
 2 files changed, 12 insertions(+), 5 deletions(-)
 create mode 100644 .changeset/red-baboons-rhyme.md

diff --git a/.changeset/red-baboons-rhyme.md b/.changeset/red-baboons-rhyme.md
new file mode 100644
index 0000000000..dcf924e912
--- /dev/null
+++ b/.changeset/red-baboons-rhyme.md
@@ -0,0 +1,9 @@
+---
+'@backstage/plugin-catalog': patch
+---
+
+Enable catalog table actions for all location types.
+
+The edit button has had support for other providers for a while and there is
+no specific reason the View in GitHub cannot work for all locations. This
+change also replaces the GitHub icon with the OpenInNew icon.
diff --git a/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx b/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx
index 15a220e839..684e0e3916 100644
--- a/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx
+++ b/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx
@@ -17,7 +17,7 @@ import { Entity } from '@backstage/catalog-model';
 import { Table, TableColumn, TableProps } from '@backstage/core';
 import { Chip, Link } from '@material-ui/core';
 import Edit from '@material-ui/icons/Edit';
-import GitHub from '@material-ui/icons/GitHub';
+import OpenInNew from '@material-ui/icons/OpenInNew';
 import { Alert } from '@material-ui/lab';
 import React from 'react';
 import { generatePath, Link as RouterLink } from 'react-router-dom';
@@ -111,13 +111,12 @@ export const CatalogTable = ({
     (rowData: Entity) => {
       const location = findLocationForEntityMeta(rowData.metadata);
       return {
-        icon: () => <GitHub fontSize="small" />,
-        tooltip: 'View on GitHub',
+        icon: () => <OpenInNew fontSize="small" />,
+        tooltip: 'View',
         onClick: () => {
           if (!location) return;
           window.open(location.target, '_blank');
         },
-        hidden: location?.type !== 'github',
       };
     },
     (rowData: Entity) => {
@@ -129,7 +128,6 @@ export const CatalogTable = ({
           if (!location) return;
           window.open(createEditLink(location), '_blank');
         },
-        hidden: location?.type !== 'github',
       };
     },
     (rowData: Entity) => {