From bfd1161dcfed4a0cd74d928469707d68e0f4d5ee Mon Sep 17 00:00:00 2001
From: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
Date: Wed, 28 Dec 2022 22:03:19 +0530
Subject: [PATCH] refactor: simplify returns

Signed-off-by: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
---
 packages/config/src/reader.ts | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/packages/config/src/reader.ts b/packages/config/src/reader.ts
index 6b0b418559..95924c45da 100644
--- a/packages/config/src/reader.ts
+++ b/packages/config/src/reader.ts
@@ -290,17 +290,13 @@ export class ConfigReader implements Config {
     if (typeof value === 'boolean' || value === undefined) {
       return value;
     }
-    let boolean;
     if (/^(?:y|yes|true|1|on)$/i.test(value as string) || value === 1) {
-      boolean = true;
-    } else if (/^(?:n|no|false|0|off)$/i.test(value as string) || value === 0) {
-      boolean = false;
-    } else {
-      throw new Error(
-        errors.convert(this.fullKey(key), this.context, 'boolean'),
-      );
+      return true;
     }
-    return boolean;
+    if (/^(?:n|no|false|0|off)$/i.test(value as string) || value === 0) {
+      return false;
+    }
+    throw new Error(errors.convert(this.fullKey(key), this.context, 'boolean'));
   }
 
   /** {@inheritdoc Config.getString} */