From 5d7a1cca09a1a198dd1eb01a1568bb25f9f7d4ad Mon Sep 17 00:00:00 2001 From: Emma Indal Date: Thu, 23 Jun 2022 11:03:12 +0200 Subject: [PATCH 1/5] point to config schema from package.json Signed-off-by: Emma Indal --- plugins/stack-overflow/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/stack-overflow/package.json b/plugins/stack-overflow/package.json index 922277c74a..0fe8ae476f 100644 --- a/plugins/stack-overflow/package.json +++ b/plugins/stack-overflow/package.json @@ -55,5 +55,6 @@ "files": [ "dist", "config" - ] + ], + "configSchema": "config.d.ts" } From 52b4f796e3432b373026877fd3dfaca01beaee0a Mon Sep 17 00:00:00 2001 From: Emma Indal Date: Thu, 23 Jun 2022 11:06:52 +0200 Subject: [PATCH 2/5] changeset Signed-off-by: Emma Indal --- .changeset/strange-tables-flash.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/strange-tables-flash.md diff --git a/.changeset/strange-tables-flash.md b/.changeset/strange-tables-flash.md new file mode 100644 index 0000000000..fd13289752 --- /dev/null +++ b/.changeset/strange-tables-flash.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-stack-overflow': patch +--- + +app-config is now picked up properly. From 635cd6e9d2d2e9698594c52bcc960d3c890d6b2c Mon Sep 17 00:00:00 2001 From: Emma Indal Date: Thu, 23 Jun 2022 11:11:12 +0200 Subject: [PATCH 3/5] same for backend plugin Signed-off-by: Emma Indal --- .changeset/strange-tables-flash.md | 1 + plugins/stack-overflow-backend/package.json | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.changeset/strange-tables-flash.md b/.changeset/strange-tables-flash.md index fd13289752..b42069aa64 100644 --- a/.changeset/strange-tables-flash.md +++ b/.changeset/strange-tables-flash.md @@ -1,5 +1,6 @@ --- '@backstage/plugin-stack-overflow': patch +'@backstage/plugin-stack-overflow-backend': patch --- app-config is now picked up properly. diff --git a/plugins/stack-overflow-backend/package.json b/plugins/stack-overflow-backend/package.json index cc41da042e..901d3b12ee 100644 --- a/plugins/stack-overflow-backend/package.json +++ b/plugins/stack-overflow-backend/package.json @@ -42,5 +42,6 @@ "files": [ "dist", "config" - ] + ], + "configSchema": "config.d.ts" } From 617e5ae30e1fa399807a06850e7c9a09c84ee4d6 Mon Sep 17 00:00:00 2001 From: Emma Indal Date: Thu, 23 Jun 2022 11:29:16 +0200 Subject: [PATCH 4/5] update config to be optional Signed-off-by: Emma Indal --- plugins/stack-overflow-backend/config.d.ts | 4 ++-- plugins/stack-overflow/config.d.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/stack-overflow-backend/config.d.ts b/plugins/stack-overflow-backend/config.d.ts index 7e7211ca33..2c39d61bfb 100644 --- a/plugins/stack-overflow-backend/config.d.ts +++ b/plugins/stack-overflow-backend/config.d.ts @@ -18,11 +18,11 @@ export interface Config { /** * Configuration options for the stack overflow plugin */ - stackoverflow: { + stackoverflow?: { /** * The base url of the Stack Overflow API used for the plugin * @visibility backend */ - baseUrl: string; + baseUrl?: string; }; } diff --git a/plugins/stack-overflow/config.d.ts b/plugins/stack-overflow/config.d.ts index 811893231e..c0638e3c19 100644 --- a/plugins/stack-overflow/config.d.ts +++ b/plugins/stack-overflow/config.d.ts @@ -18,11 +18,11 @@ export interface Config { /** * Configuration options for the stack overflow plugin */ - stackoverflow: { + stackoverflow?: { /** * The base url of the Stack Overflow API used for the plugin * @visibility frontend */ - baseUrl: string; + baseUrl?: string; }; } From a47c1b1407162bdf48906d374eef91a0d4ff2c7b Mon Sep 17 00:00:00 2001 From: Emma Indal Date: Thu, 23 Jun 2022 13:29:40 +0200 Subject: [PATCH 5/5] add config.d.ts to files Signed-off-by: Emma Indal --- plugins/stack-overflow-backend/package.json | 2 +- plugins/stack-overflow/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/stack-overflow-backend/package.json b/plugins/stack-overflow-backend/package.json index 901d3b12ee..083ab18b42 100644 --- a/plugins/stack-overflow-backend/package.json +++ b/plugins/stack-overflow-backend/package.json @@ -41,7 +41,7 @@ }, "files": [ "dist", - "config" + "config.d.ts" ], "configSchema": "config.d.ts" } diff --git a/plugins/stack-overflow/package.json b/plugins/stack-overflow/package.json index 0fe8ae476f..793e42881d 100644 --- a/plugins/stack-overflow/package.json +++ b/plugins/stack-overflow/package.json @@ -54,7 +54,7 @@ }, "files": [ "dist", - "config" + "config.d.ts" ], "configSchema": "config.d.ts" }