diff --git a/.changeset/silent-numbers-retire.md b/.changeset/silent-numbers-retire.md index b386d04b14..ff5f11ecee 100644 --- a/.changeset/silent-numbers-retire.md +++ b/.changeset/silent-numbers-retire.md @@ -1,6 +1,6 @@ --- -'@backstage/plugin-vault-backend': minor -'@backstage/plugin-vault': minor +'@backstage/plugin-vault-backend': patch +'@backstage/plugin-vault': patch --- Added ability to override vault secret engine value on catalog entity level using annotation `vault.io/secrets-engine` diff --git a/plugins/vault-backend/src/service/vaultApi.ts b/plugins/vault-backend/src/service/vaultApi.ts index d785e135df..7c3ccc1d00 100644 --- a/plugins/vault-backend/src/service/vaultApi.ts +++ b/plugins/vault-backend/src/service/vaultApi.ts @@ -133,8 +133,8 @@ export class VaultClient implements VaultApi { const listUrl = this.vaultConfig.kvVersion === 2 - ? `v1/${mount}/metadata/${secretPath}` - : `v1/${mount}/${secretPath}`; + ? `v1/${encodeURIComponent(mount)}/metadata/${secretPath}` + : `v1/${encodeURIComponent(mount)}/${secretPath}`; const result = await this.limit(() => this.callApi(listUrl, { list: true }), ); @@ -157,8 +157,12 @@ export class VaultClient implements VaultApi { secrets.push({ name: secret, path: secretPath, - editUrl: `${vaultUrl}/ui/vault/secrets/${mount}/edit/${secretPath}/${secret}`, - showUrl: `${vaultUrl}/ui/vault/secrets/${mount}/show/${secretPath}/${secret}`, + editUrl: `${vaultUrl}/ui/vault/secrets/${encodeURIComponent( + mount, + )}/edit/${secretPath}/${secret}`, + showUrl: `${vaultUrl}/ui/vault/secrets/${encodeURIComponent( + mount, + )}/show/${secretPath}/${secret}`, }); } }),