paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 37 Packages Projects Releases Wiki Activity

address review comments

Browse Source 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
This commit is contained in:
Fredrik Adelöw
2022-01-13 11:16:16 +01:00
parent 28b61f32b4
commit be610c5744
10 changed files with 70 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/auth/google/gcp-iap-auth.md
+3 -3
View File
@@ -95,7 +95,7 @@ sign-in mechanism to poll that endpoint through the IAP, on the user's behalf.
## Frontend Changes
Any Backstage app needs a `SignInPage` to be configured. Its purpose is to
All Backstage apps need a `SignInPage` to be configured. Its purpose is to
establish who the user is and what their identifying credentials are, blocking
rendering the rest of the UI until that's complete, and then keeping those
credentials fresh.
@@ -114,11 +114,11 @@ component for this purpose out of the box.
Update your `createApp` call in `packages/app/src/App.tsx`, as follows.
```diff
+import { DelegatedSignInPage } from '@backstage/core-components';
+import { ProxiedSignInPage } from '@backstage/core-components';
const app = createApp({
components: {
+ SignInPage: props => <DelegatedSignInPage {...props} provider="gcp-iap" />,
+ SignInPage: props => <ProxiedSignInPage {...props} provider="gcp-iap" />,
```
After this, your app should be ready to leverage the Identity-Aware Proxy for