From be4fa53fab8602f632a641ab0d762e18fa40611e Mon Sep 17 00:00:00 2001 From: David Weber Date: Sun, 7 May 2023 16:04:54 +0200 Subject: [PATCH] fix: fix description links when clicking entry in radar Signed-off-by: David Weber --- .changeset/fair-suits-warn.md | 5 +++++ plugins/tech-radar/src/components/RadarEntry/RadarEntry.tsx | 3 +++ plugins/tech-radar/src/components/RadarPlot/RadarPlot.tsx | 1 + 3 files changed, 9 insertions(+) create mode 100644 .changeset/fair-suits-warn.md diff --git a/.changeset/fair-suits-warn.md b/.changeset/fair-suits-warn.md new file mode 100644 index 0000000000..3edc2aa1ca --- /dev/null +++ b/.changeset/fair-suits-warn.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-tech-radar': patch +--- + +Fix description links when clicking entry in radar. diff --git a/plugins/tech-radar/src/components/RadarEntry/RadarEntry.tsx b/plugins/tech-radar/src/components/RadarEntry/RadarEntry.tsx index af9e840ead..66940cd1d7 100644 --- a/plugins/tech-radar/src/components/RadarEntry/RadarEntry.tsx +++ b/plugins/tech-radar/src/components/RadarEntry/RadarEntry.tsx @@ -26,6 +26,7 @@ export type Props = { value: number; color: string; url?: string; + links?: Array<{ title: string; url: string }>; moved?: number; description?: string; timeline?: EntrySnapshot[]; @@ -73,6 +74,7 @@ const RadarEntry = (props: Props): JSX.Element => { title, color, url, + links, value, x, y, @@ -112,6 +114,7 @@ const RadarEntry = (props: Props): JSX.Element => { description={description ? description : 'no description'} timeline={timeline ? timeline : []} url={url} + links={links} /> )} {description ? ( diff --git a/plugins/tech-radar/src/components/RadarPlot/RadarPlot.tsx b/plugins/tech-radar/src/components/RadarPlot/RadarPlot.tsx index 957017692b..0fb6e3a36a 100644 --- a/plugins/tech-radar/src/components/RadarPlot/RadarPlot.tsx +++ b/plugins/tech-radar/src/components/RadarPlot/RadarPlot.tsx @@ -73,6 +73,7 @@ const RadarPlot = (props: Props): JSX.Element => { color={entry.color || ''} value={(entry?.index || 0) + 1} url={entry.url} + links={entry.links} description={entry.description} moved={entry.moved} title={entry.title}