From be2cd474066e89be95a85dbbd5178c0aee3fdfc6 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 19 Aug 2021 00:25:44 +0200 Subject: [PATCH] dev-utils: fix busy refresh loop Signed-off-by: Patrik Oldsberg --- .changeset/great-needles-lay.md | 5 +++++ packages/dev-utils/src/devApp/render.tsx | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 .changeset/great-needles-lay.md diff --git a/.changeset/great-needles-lay.md b/.changeset/great-needles-lay.md new file mode 100644 index 0000000000..d6043f7512 --- /dev/null +++ b/.changeset/great-needles-lay.md @@ -0,0 +1,5 @@ +--- +'@backstage/dev-utils': patch +--- + +Fixed busy refresh loop that happened when registering a page at `/`. diff --git a/packages/dev-utils/src/devApp/render.tsx b/packages/dev-utils/src/devApp/render.tsx index 661a93e8b0..38cc0befe1 100644 --- a/packages/dev-utils/src/devApp/render.tsx +++ b/packages/dev-utils/src/devApp/render.tsx @@ -227,7 +227,11 @@ class DevAppBuilder { const DevApp = hot(hotModule)(this.build()); - if (window.location.pathname === '/' && this.defaultPage) { + if ( + window.location.pathname === '/' && + this.defaultPage && + this.defaultPage !== '/' + ) { window.location.pathname = this.defaultPage; }