From be14c351ce1ac63e965d2ed972348226147179f5 Mon Sep 17 00:00:00 2001 From: Joe Porpeglia Date: Tue, 12 Apr 2022 09:57:12 -0400 Subject: [PATCH] Use isPermission helper in test policy for plugin authors Signed-off-by: Joe Porpeglia --- .../plugin-authors/02-adding-a-basic-permission-check.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/permission/plugin-authors/02-adding-a-basic-permission-check.md b/docs/permission/plugin-authors/02-adding-a-basic-permission-check.md index 776bde0d97..b561fd8059 100644 --- a/docs/permission/plugin-authors/02-adding-a-basic-permission-check.md +++ b/docs/permission/plugin-authors/02-adding-a-basic-permission-check.md @@ -131,6 +131,8 @@ In order to test the logic above, the integrators of your backstage instance nee PermissionPolicy, + PolicyQuery, } from '@backstage/plugin-permission-node'; ++ import { isPermission } from '@backstage/plugin-permission-common'; ++ import { todosListCreate } from '@internal/plugin-todo-list-backend'; class TestPermissionPolicy implements PermissionPolicy { - async handle(): Promise { @@ -138,7 +140,7 @@ In order to test the logic above, the integrators of your backstage instance nee + request: PolicyQuery, + user?: BackstageIdentityResponse, + ): Promise { -+ if (request.permission.name === 'todos.list.create') { ++ if (isPermission(request.permission, todosListCreate)) { + return { + result: AuthorizeResult.DENY, + };