paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 26 Packages Projects Releases Wiki Activity

chore: replace GITHUB_ACTIONS_ANNOTATION with const for now as we need a release of the github-actions-plugin first

Browse Source
This commit is contained in:
blam
2020-12-15 19:48:11 +01:00
parent f76a8aedf4
commit bdd10ca66f
4 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/github-actions/src/components/Cards/Cards.tsx
+4 -1
View File
@@ -32,7 +32,10 @@ import {
useApi,
} from '@backstage/core';
import ExternalLinkIcon from '@material-ui/icons/Launch';
import { GITHUB_ACTIONS_ANNOTATION } from '../../../universal';
// TODO(blam): Replace with the universal import from github-actions after a release
// As it will break the E2E without it
const GITHUB_ACTIONS_ANNOTATION = 'github.com/project-slug';
const useStyles = makeStyles<Theme>({
externalLinkIcon: {
plugins/github-actions/src/components/Cards/RecentWorkflowRunsCard.tsx
+4 -1
View File
@@ -15,7 +15,6 @@
*/
import { Entity } from '@backstage/catalog-model';
import { errorApiRef, useApi } from '@backstage/core-api';
import { GITHUB_ACTIONS_ANNOTATION } from '../../../universal';
import { useWorkflowRuns } from '../useWorkflowRuns';
import React, { useEffect } from 'react';
import { EmptyState, InfoCard, Table } from '@backstage/core';
@@ -23,6 +22,10 @@ import { WorkflowRunStatus } from '../WorkflowRunStatus';
import { Button, Link } from '@material-ui/core';
import { generatePath, Link as RouterLink } from 'react-router-dom';
// TODO(blam): Replace with the universal import from github-actions after a release
// As it will break the E2E without it
const GITHUB_ACTIONS_ANNOTATION = 'github.com/project-slug';
const firstLine = (message: string): string => message.split('\n')[0];
export type Props = {
plugins/github-actions/src/components/Router.tsx
+4 -1
View File
@@ -19,9 +19,12 @@ import { Routes, Route } from 'react-router';
import { rootRouteRef, buildRouteRef } from '../plugin';
import { WorkflowRunDetails } from './WorkflowRunDetails';
import { WorkflowRunsTable } from './WorkflowRunsTable';
import { GITHUB_ACTIONS_ANNOTATION } from '../../universal';
import { MissingAnnotationEmptyState } from '@backstage/core';
// TODO(blam): Replace with the universal import from github-actions after a release
// As it will break the E2E without it
const GITHUB_ACTIONS_ANNOTATION = 'github.com/project-slug';
export const isPluginApplicableToEntity = (entity: Entity) =>
Boolean(entity.metadata.annotations?.[GITHUB_ACTIONS_ANNOTATION]);