From bd671414bbb6c00e57188f115db594b3033135c6 Mon Sep 17 00:00:00 2001 From: Johan Persson Date: Tue, 3 Mar 2026 12:45:36 +0100 Subject: [PATCH] fix(ui): remove unused style prop from ButtonIconOwnProps The style prop was defined in ButtonIconOwnProps but never destructured or applied in the component, causing it to be silently dropped. Removing it lets style flow through to the underlying RAC Button via restProps instead. Signed-off-by: Johan Persson --- packages/ui/src/components/ButtonIcon/definition.ts | 1 - packages/ui/src/components/ButtonIcon/types.ts | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/ui/src/components/ButtonIcon/definition.ts b/packages/ui/src/components/ButtonIcon/definition.ts index 76f6be68ce..0027227094 100644 --- a/packages/ui/src/components/ButtonIcon/definition.ts +++ b/packages/ui/src/components/ButtonIcon/definition.ts @@ -36,6 +36,5 @@ export const ButtonIconDefinition = defineComponent()({ loading: { dataAttribute: true }, icon: {}, className: {}, - style: {}, }, }); diff --git a/packages/ui/src/components/ButtonIcon/types.ts b/packages/ui/src/components/ButtonIcon/types.ts index 92618d5ff6..f30f01ff99 100644 --- a/packages/ui/src/components/ButtonIcon/types.ts +++ b/packages/ui/src/components/ButtonIcon/types.ts @@ -14,7 +14,7 @@ * limitations under the License. */ -import type { ReactElement, CSSProperties } from 'react'; +import type { ReactElement } from 'react'; import type { ButtonProps as RAButtonProps } from 'react-aria-components'; import type { Responsive } from '../../types'; @@ -25,7 +25,6 @@ export type ButtonIconOwnProps = { icon?: ReactElement; loading?: boolean; className?: string; - style?: CSSProperties; }; /** @@ -34,5 +33,5 @@ export type ButtonIconOwnProps = { * @public */ export interface ButtonIconProps - extends Omit, + extends Omit, ButtonIconOwnProps {}