From bc93253806f8db0a7c584bce56e703dc34942b96 Mon Sep 17 00:00:00 2001
From: Renan Mendes Carvalho <aitherios@gmail.com>
Date: Mon, 18 Sep 2023 10:56:14 +0200
Subject: [PATCH] refactor(plugins/home): Keep api-report concise.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This patch remove parameter destructuring to simplify api-report
reads.

Signed-off-by: Renan Mendes Carvalho <aitherios@gmail.com>
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
---
 plugins/home/api-report.md                    |  6 +-----
 plugins/home/src/api/CoreStorageVisitsApi.ts  | 12 ++++--------
 plugins/home/src/api/LocalStorageVisitsApi.ts |  9 +++------
 plugins/home/src/api/VisitsApiFactory.ts      | 12 ++++--------
 4 files changed, 12 insertions(+), 27 deletions(-)

diff --git a/plugins/home/api-report.md b/plugins/home/api-report.md
index 38ae82aa7c..9271d00492 100644
--- a/plugins/home/api-report.md
+++ b/plugins/home/api-report.md
@@ -265,11 +265,7 @@ export interface VisitsApi {
 
 // @public
 export class VisitsApiFactory implements VisitsApi {
-  protected constructor({
-    limit,
-    retrieveAll,
-    persistAll,
-  }: VisitsApiFactoryOptions);
+  protected constructor(options: VisitsApiFactoryOptions);
   // (undocumented)
   protected readonly limit: number;
   // (undocumented)
diff --git a/plugins/home/src/api/CoreStorageVisitsApi.ts b/plugins/home/src/api/CoreStorageVisitsApi.ts
index e392c2f30c..18cdaca90f 100644
--- a/plugins/home/src/api/CoreStorageVisitsApi.ts
+++ b/plugins/home/src/api/CoreStorageVisitsApi.ts
@@ -37,14 +37,10 @@ export class CoreStorageVisitsApi extends VisitsApiFactory {
     return new CoreStorageVisitsApi(options);
   }
 
-  private constructor({
-    storageApi,
-    identityApi,
-    limit = 100,
-  }: CoreStorageVisitsApiOptions) {
-    super({ limit });
-    this.storageApi = storageApi;
-    this.identityApi = identityApi;
+  private constructor(options: CoreStorageVisitsApiOptions) {
+    super({ limit: options.limit ?? 100 });
+    this.storageApi = options.storageApi;
+    this.identityApi = options.identityApi;
     this.retrieveAll = async (): Promise<Array<Visit>> => {
       let visits: Array<Visit>;
       const { userEntityRef } = await this.identityApi.getBackstageIdentity();
diff --git a/plugins/home/src/api/LocalStorageVisitsApi.ts b/plugins/home/src/api/LocalStorageVisitsApi.ts
index 42f8495a5e..44932b93f5 100644
--- a/plugins/home/src/api/LocalStorageVisitsApi.ts
+++ b/plugins/home/src/api/LocalStorageVisitsApi.ts
@@ -36,12 +36,9 @@ export class LocalStorageVisitsApi extends VisitsApiFactory {
     return new LocalStorageVisitsApi(options);
   }
 
-  private constructor({
-    limit = 100,
-    identityApi,
-  }: LocalStorageVisitsApiOptions) {
-    super({ limit });
-    this.identityApi = identityApi;
+  private constructor(options: LocalStorageVisitsApiOptions) {
+    super({ limit: options.limit ?? 100 });
+    this.identityApi = options.identityApi;
     this.retrieveAll = async (): Promise<Array<Visit>> => {
       let visits: Array<Visit>;
       const { userEntityRef } = await this.identityApi.getBackstageIdentity();
diff --git a/plugins/home/src/api/VisitsApiFactory.ts b/plugins/home/src/api/VisitsApiFactory.ts
index 48952c0a1c..e83bcef723 100644
--- a/plugins/home/src/api/VisitsApiFactory.ts
+++ b/plugins/home/src/api/VisitsApiFactory.ts
@@ -42,14 +42,10 @@ export class VisitsApiFactory implements VisitsApi {
   protected retrieveAll: () => Promise<Array<Visit>>;
   protected persistAll: (visits: Array<Visit>) => Promise<void>;
 
-  protected constructor({
-    limit = 100,
-    retrieveAll,
-    persistAll,
-  }: VisitsApiFactoryOptions) {
-    this.limit = Math.abs(limit);
-    this.retrieveAll = retrieveAll ?? (async () => []);
-    this.persistAll = persistAll ?? (async () => {});
+  protected constructor(options: VisitsApiFactoryOptions) {
+    this.limit = Math.abs(options.limit ?? 100);
+    this.retrieveAll = options.retrieveAll ?? (async () => []);
+    this.persistAll = options.persistAll ?? (async () => {});
   }
 
   async list(queryParams?: VisitsApiQueryParams): Promise<Visit[]> {