From bc4ab9fcf69073211e9256105fbff56f5bddaebd Mon Sep 17 00:00:00 2001 From: ovalice <31350208+ovalice@users.noreply.github.com> Date: Sun, 7 Apr 2024 00:29:27 +0200 Subject: [PATCH] Use writableEnded to determine whether logStream was closed during test When asserting whether the logStream is closed, the .closed prop is not sufficient. The prop only becomes true when all the data has been flushed, which probably happens after we want to do the assertion. By using .writableEnded, we can properly check whether the logStream was intentionally closed, as it becomes true as soon as .end() is called. Signed-off-by: ovalice <31350208+ovalice@users.noreply.github.com> --- .../backend-common/src/util/KubernetesContainerRunner.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/backend-common/src/util/KubernetesContainerRunner.test.ts b/packages/backend-common/src/util/KubernetesContainerRunner.test.ts index 7b55f8cd42..2be2ec64ef 100644 --- a/packages/backend-common/src/util/KubernetesContainerRunner.test.ts +++ b/packages/backend-common/src/util/KubernetesContainerRunner.test.ts @@ -203,7 +203,7 @@ describeIfKubernetes('KubernetesContainerRunner', () => { await containerRunner.runContainer(runOptions); - expect(logStream.closed).toBe(false); + expect(logStream.writableEnded).toBe(false); }); describe('with namespace test', () => {