From ec64d9590cbb4dad0f8832da7f41e7a02e8115bd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= <freben@gmail.com>
Date: Sat, 6 Nov 2021 10:25:17 +0100
Subject: [PATCH] Call the super constructor early
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
---
 .changeset/nice-tools-cheat.md |  5 +++++
 packages/cli/src/lib/errors.ts | 10 +++++-----
 2 files changed, 10 insertions(+), 5 deletions(-)
 create mode 100644 .changeset/nice-tools-cheat.md

diff --git a/.changeset/nice-tools-cheat.md b/.changeset/nice-tools-cheat.md
new file mode 100644
index 0000000000..c4f0e162bf
--- /dev/null
+++ b/.changeset/nice-tools-cheat.md
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+Make `ExitCodeError` call `super` early to avoid compiler warnings
diff --git a/packages/cli/src/lib/errors.ts b/packages/cli/src/lib/errors.ts
index c0b4c45b6c..dd3955a10a 100644
--- a/packages/cli/src/lib/errors.ts
+++ b/packages/cli/src/lib/errors.ts
@@ -26,11 +26,11 @@ export class ExitCodeError extends CustomError {
   readonly code: number;
 
   constructor(code: number, command?: string) {
-    if (command) {
-      super(`Command '${command}' exited with code ${code}`);
-    } else {
-      super(`Child exited with code ${code}`);
-    }
+    super(
+      command
+        ? `Command '${command}' exited with code ${code}`
+        : `Child exited with code ${code}`,
+    );
     this.code = code;
   }
 }